Skip to content

Revert "Fix how Gradle resolves Android plugin" #98050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 8, 2022
Merged

Revert "Fix how Gradle resolves Android plugin" #98050

fluttergithubbot merged 1 commit into from
Feb 8, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Feb 8, 2022

Reverts #97823

Due to #98048

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 8, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 8, 2022
stuartmorgan-g
stuartmorgan-g approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit d2b5f34 into master Feb 8, 2022
@fluttergithubbot fluttergithubbot deleted the revert-97823-fix_gradle_plugin_resol branch February 8, 2022 20:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
99bf12a 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
dd35503 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
9745339 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
33526d7 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
d030552 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
eef54fd 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
227411f 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
999cebb 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
1f60787 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
db2d025 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
91eb2e3 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
3b8dbd8 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
4c743ec 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
8228459 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
9dcd32f 
…ter#98050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
6d60510 
…ter#98050)
@stuartmorgan-g stuartmorgan-g mentioned this pull request Feb 9, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
d2b5f34 Revert "Fix how Gradle resolves Android plugin" (flutter/flut…
6a2ce10 
…ter#98050)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Revert "Fix how Gradle resolves Android plugin" (flutter#98050)
62343d4
@gnprice gnprice mentioned this pull request Apr 18, 2023
Closed
@Gustl22 Gustl22 mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @stuartmorgan-g @GaryQian @fluttergithubbot