Starts using the `--source` flag to compile the dart registrant. #98046

gaaclarke · 2022-02-08T18:39:27Z

The hack we did previously to shadow the main entrypoint wasn't working on release builds. Now that Dart supports the --source flag we can avoid shadowing main which fixes the issue and is a more clear solution.

fixes #91841

companion engine pr: flutter/engine#31418

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dev/devicelab/bin/tasks/entrypoint_dart_registrant.dart

gaaclarke · 2022-02-14T18:53:55Z

Mac dart_plugin_registry_test will fail until the engine PR lands.

…nt. (flutter/flutter#98046)

…nt. (flutter#98046)" This reverts commit fdcd144.

…nt. (#98046) (#100493)

…nt. (flutter#98046) (flutter#100493)"

…t. (#98046)" (#100572)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 8, 2022

gaaclarke mentioned this pull request Feb 8, 2022

Multiple entry-points in same Dart file is broken #91841

Closed

gaaclarke force-pushed the use-source-dart-registrant branch from 11dd2ab to 30972d7 Compare February 9, 2022 18:05

This comment was marked as outdated.

Sign in to view

gaaclarke force-pushed the use-source-dart-registrant branch from 2f4c1b8 to e8c4c68 Compare February 10, 2022 01:20

This comment was marked as outdated.

Sign in to view

gaaclarke force-pushed the use-source-dart-registrant branch 11 times, most recently from 4bc3b73 to 3499ec3 Compare February 11, 2022 19:31

This comment was marked as outdated.

Sign in to view

gaaclarke mentioned this pull request Feb 12, 2022

Started looking for the dart plugin registrant at runtime flutter/engine#31418

Merged

8 tasks

gaaclarke force-pushed the use-source-dart-registrant branch from 468b1cc to 989ebd7 Compare February 14, 2022 18:16

flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 14, 2022

gaaclarke commented Feb 14, 2022

View reviewed changes

dev/devicelab/bin/tasks/entrypoint_dart_registrant.dart Outdated Show resolved Hide resolved

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

1ff9917

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

1c96a5a

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

73dd5f2

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

98f1c55

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

05cc5ef

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

e9c6f04

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

59cda11

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

a7bc2f8

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

ce89a5e

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

74800e1

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

7984d64

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

e2e71c6

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

1a59b54

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

042b831

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

fa7b234

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

027d7dd

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

e39c0c4

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

cfbfca3

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

55b7259

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

d77c1ca

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

efc1488

…nt. (flutter/flutter#98046)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

fdcd144 Starts using the --source flag to compile the dart registra…

e6472cd

…nt. (flutter/flutter#98046)

gaaclarke mentioned this pull request Mar 21, 2022

Revert "Started looking for the dart plugin registrant at runtime (#31418) flutter/engine#32162

Merged

8 tasks

gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Mar 21, 2022

Revert "Starts using the --source flag to compile the dart registra…

f56cf63

…nt. (flutter#98046)" This reverts commit fdcd144.

fluttergithubbot pushed a commit that referenced this pull request Mar 21, 2022

Revert "Starts using the --source flag to compile the dart registra…

9725897

…nt. (#98046) (#100493)

gaaclarke mentioned this pull request Mar 24, 2022

Relands "Starts using the --source flag to compile the dart registrant. (#98046)" #100572

Merged

8 tasks

gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Mar 24, 2022

Reland "Starts using the --source flag to compile the dart registra…

a5fd17c

…nt. (flutter#98046) (flutter#100493)"

fluttergithubbot pushed a commit that referenced this pull request Mar 29, 2022

Relands "Starts using the --source flag to compile the dart registran…

912873b

…t. (#98046)" (#100572)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Starts using the `--source` flag to compile the dart registrant. #98046

Starts using the `--source` flag to compile the dart registrant. #98046

Uh oh!

gaaclarke commented Feb 8, 2022 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

gaaclarke commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Starts using the --source flag to compile the dart registrant. #98046

Starts using the --source flag to compile the dart registrant. #98046

Uh oh!

Conversation

gaaclarke commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

gaaclarke commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Starts using the `--source` flag to compile the dart registrant. #98046

Starts using the `--source` flag to compile the dart registrant. #98046

gaaclarke commented Feb 8, 2022 •

edited

Loading