Skip to content

Add keyLog and connectionFactory to HttpClient implementations #98045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 6 commits into from
Feb 11, 2022
Merged

Add keyLog and connectionFactory to HttpClient implementations #98045

fluttergithubbot merged 6 commits into from
Feb 11, 2022

Conversation

@brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Feb 8, 2022 •
edited
Loading

Add two setters that will be added in Dart 2.7:
dart-lang/sdk#48093
dart-lang/sdk#47887

One this PR is merged, my plan is to fill another issue (assigned to myself) to remove the // ignore: override_on_non_overriding_member comments when the engine has been updated to Dart 2.17.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 8, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 8, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@brianquinlan
Copy link
Contributor Author

brianquinlan commented Feb 9, 2022

Hey @zanderso , can I submit this now or should I get test approval from @Hixie ?

@zanderso
Copy link
Member

zanderso commented Feb 9, 2022

Yes get approval.

@Hixie
Copy link
Contributor

Hixie commented Feb 9, 2022

test-exempt: fixes tests that would otherwise break in the future

@brianquinlan
Copy link
Contributor Author

brianquinlan commented Feb 9, 2022

@zanderso I don't have write access to this repository - could you press the merge button?

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 10, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot merged commit 76855aa into flutter:master Feb 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
35a29fa 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
b2b2228 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
2cc9c9c 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
c4946fe 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
774d265 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
26c3ba1 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
55bb816 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
05c5099 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
04dd2b0 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
cf44b40 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
63fee92 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
dac693b 
…tions (flutter/flutter#98045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
76855aa Add keyLog and connectionFactory to HttpClient implementa…
183b830 
…tions (flutter/flutter#98045)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@brianquinlan @clocksmith
Add keyLog and connectionFactory to HttpClient implementations (f…
d7613e7 
…lutter#98045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aam aam aam approved these changes

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianquinlan @zanderso @Hixie @fluttergithubbot @aam