Skip to content

Fix NavigationRail Indicator alignment for NavigationRailLabelType.none #98028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Feb 11, 2022
Merged

Fix NavigationRail Indicator alignment for NavigationRailLabelType.none #98028

fluttergithubbot merged 5 commits into from
Feb 11, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 8, 2022

Details: #97753 (comment)

fixes #97753

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 8, 2022
@TahaTesser TahaTesser requested a review from HansMuller February 8, 2022 12:46
@HansMuller HansMuller requested a review from johnsonmh February 10, 2022 19:40
johnsonmh
johnsonmh approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@johnsonmh johnsonmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix

HansMuller
HansMuller approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 21de850 into flutter:master Feb 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
529e819 
…elType.none` (flutter/flutter#98028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
08f397c 
…elType.none` (flutter/flutter#98028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
3e2f774 
…elType.none` (flutter/flutter#98028)
@TahaTesser TahaTesser deleted the fix_navigation_rail_indictor_align branch February 11, 2022 08:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
195fbe4 
…elType.none` (flutter/flutter#98028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
152930b 
…elType.none` (flutter/flutter#98028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
f087039 
…elType.none` (flutter/flutter#98028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
c297f76 
…elType.none` (flutter/flutter#98028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
21de850 Fix NavigationRail Indicator alignment for `NavigationRailLab…
34c9821 
…elType.none` (flutter/flutter#98028)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Fix NavigationRail Indicator alignment for `NavigationRailLabelType.n…
8474c78 
…one` (flutter#98028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsonmh johnsonmh johnsonmh approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NavigationRailDestination icons are incorrectly aligned with labelType set to NavigationRailLabelType.none

4 participants

@TahaTesser @HansMuller @johnsonmh @fluttergithubbot