Skip to content

Added performance benchmarks to background platform channels for iOS. #97991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaaclarke merged 4 commits into from
Feb 16, 2022
Merged

Added performance benchmarks to background platform channels for iOS. #97991

gaaclarke merged 4 commits into from
Feb 16, 2022

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Feb 8, 2022

issue: #91635

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 8, 2022
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 8, 2022

I had to switch the host code from Swift to ObjC because of #97968. I think that might be a local problem for my build system but I couldn't seem to resolve it.

@gaaclarke gaaclarke marked this pull request as ready for review February 8, 2022 00:07
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 8, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gaaclarke gaaclarke requested a review from dnfield February 8, 2022 00:07
@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 8, 2022

Here are the local results for the tests:

flutter: BasicMessageChannel/StandardMessageCodec/Flutter->Host/Small: 55.2 µs
BasicMessageChannel/StandardMessageCodec/Flutter->Host/Large: 757.5 µs
BasicMessageChannel/BinaryCodec/Flutter->Host/Large: 53.9 µs
BasicMessageChannel/BinaryCodec/Flutter->Host/1MB: 314.4 µs
BasicMessageChannel/StandardMessageCodec/Flutter->Host/SmallParallel3: 28.4 µs
BasicMessageChannel/StandardMessageCodec/Flutter->Host (background)/Small: 43.7 µs
BasicMessageChannel/StandardMessageCodec/Flutter->Host (background)/SmallParallel3: 23.6 µs

20% reduction on small payloads serialized, 17% reduction on parallel small payloads.

@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 9, 2022

friendly ping @dnfield

dnfield
dnfield reviewed Feb 15, 2022
View reviewed changes
dev/benchmarks/platform_channels_benchmarks/lib/main.dart
required String name,
required int numMessages,
}) async {
print('running $name');
Copy link
Contributor

@dnfield dnfield Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this going to be helpful in CI logs, or will it add more noise to an already noisy log?

Copy link
Member Author

@gaaclarke gaaclarke Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be useful. It only prints out about 10 things. It's especially useful when running locally since the benchmarks can leave the console inactive for multiple minutes.

dnfield
dnfield reviewed Feb 15, 2022
View reviewed changes
dev/benchmarks/platform_channels_benchmarks/lib/main.dart Outdated
);
await _runTest(
test: (int x) =>
_runBasicStandardParallel(backgroundStandard, x, 1234, 3),
Copy link
Contributor

@dnfield dnfield Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no newline

Copy link
Member Author

@gaaclarke gaaclarke Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

dnfield
dnfield approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Feb 16, 2022

@renyou @angjieli another issue with Google testing missing this PR. Is there a tracking issue for these types of bugs? FRoB says this PR already exists in the database when I tried to trigger it

@gaaclarke
Copy link
Member Author

gaaclarke commented Feb 16, 2022

Since this is just adding a test and the google testing step is hung @CaseyHillers says I can land this without it.

@gaaclarke gaaclarke merged commit 7c3f79f into flutter:master Feb 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
7c3f79f Added performance benchmarks to background platform channels …
3a3c94a 
…for iOS. (flutter/flutter#97991)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
7c3f79f Added performance benchmarks to background platform channels …
f2413ef 
…for iOS. (flutter/flutter#97991)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 16, 2022
@engine-flutter-autoroll
7c3f79f Added performance benchmarks to background platform channels …
dbe8bcf 
…for iOS. (flutter/flutter#97991)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@gaaclarke @clocksmith
Added performance benchmarks to background platform channels for iOS. (…
bb8388e 
…flutter#97991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke @CaseyHillers @dnfield