Skip to content

Expose smart punctuation options on CupertinoSearchTextField #97980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Jun 22, 2022
Merged

Expose smart punctuation options on CupertinoSearchTextField #97980

auto-submit merged 4 commits into from
Jun 22, 2022

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Feb 7, 2022 •
edited
Loading

Let users of CupertinoSearchTextField choose to disable automatic directional quotes, en-dashes, and em-dashes.

Fixes #102058

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Feb 7, 2022
@moffatman moffatman force-pushed the search_field_quotes branch from 408a051 to e45e38a Compare February 7, 2022 22:52
@moffatman moffatman force-pushed the search_field_quotes branch from b9c431d to 48ecffd Compare March 11, 2022 23:14
@skia-gold
Copy link

skia-gold commented Mar 11, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/97980

@moffatman moffatman force-pushed the search_field_quotes branch from 48ecffd to e5b9042 Compare March 29, 2022 22:41
@moffatman moffatman force-pushed the search_field_quotes branch from e5b9042 to 5437dec Compare April 18, 2022 05:07
guidezpl
guidezpl requested changes May 2, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all familiar with this mechanism, but this needs a test to validate behavior.

@moffatman
Copy link
Contributor Author

moffatman commented May 2, 2022

@guidezpl There is a test here, it's just a change to pass-through an option to a child Widget.

guidezpl
guidezpl approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shouldn't review on my phone :). LGTM

@moffatman moffatman force-pushed the search_field_quotes branch from 5437dec to 37d0d35 Compare May 14, 2022 17:06
@guidezpl
Copy link
Member

guidezpl commented May 16, 2022

Running Google testing again

@moffatman
Copy link
Contributor Author

moffatman commented Jun 15, 2022

@guidezpl Can you press the merge button?

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jun 15, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@moffatman
Copy link
Contributor Author

moffatman commented Jun 15, 2022

@guidezpl Guess it needs 1 more approval

@guidezpl
Copy link
Member

guidezpl commented Jun 15, 2022

Can you post a link in the Discord for a review?

LongCatIsLooong
LongCatIsLooong approved these changes Jun 16, 2022
View reviewed changes
packages/flutter/lib/src/cupertino/search_field.dart Outdated
/// character will be automatically replaced by a left or right double quote
/// depending on its position in a word.
///
/// Defaults to true.
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: something like "Defaults to null which uses the default smart quote behavior specified on the platform"?

Same for smart dashes.

Copy link
Contributor Author

@moffatman moffatman Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually looked into it, the default platform behavior is never used. It will either be forced to yes or no. But I updated the comment to explain that.

@moffatman moffatman force-pushed the search_field_quotes branch from 37d0d35 to 82bae95 Compare June 17, 2022 05:07
@moffatman
Copy link
Contributor Author

moffatman commented Jun 22, 2022

@guidezpl Can you now press the merge button?

@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2022
@auto-submit auto-submit bot merged commit 20da401 into flutter:master Jun 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
29cb346 
…lutter/flutter#97980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
e334f72 
…lutter/flutter#97980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
52831b3 
…lutter/flutter#97980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
c3dc333 
…lutter/flutter#97980)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
9f402aa 
…lutter/flutter#97980)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@moffatman @camsim99
Expose smart punctuation options on CupertinoSearchTextField (flutter…
d37818f 
…#97980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
2edc738 
…lutter/flutter#97980)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
20da401 Expose smart punctuation options on CupertinoSearchTextField (f…
0d754f8 
…lutter/flutter#97980)
@justinmc justinmc mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Allow disabling smart-quotes in CupertinoSearchTextField

5 participants

@moffatman @skia-gold @guidezpl @fluttergithubbot @LongCatIsLooong