Skip to content

CheckboxListTile: Replace toggleableActiveColor with CheckboxTheme color property #97970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TahaTesser wants to merge 2 commits into from
Closed

CheckboxListTile: Replace toggleableActiveColor with CheckboxTheme color property #97970

TahaTesser wants to merge 2 commits into from

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 7, 2022

Details: #95870 (comment)
Related: #97965

This PR replacestoggleableActiveColor as it is soon to be deprecated.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 7, 2022
@TahaTesser TahaTesser force-pushed the checkboxlisttile_active_color_theme branch from bd9f16e to 52d373d Compare February 7, 2022 18:34
@guidezpl guidezpl requested a review from HansMuller February 8, 2022 08:00
@TahaTesser TahaTesser force-pushed the checkboxlisttile_active_color_theme branch from 52d373d to a2ae2bf Compare February 8, 2022 23:21
@TahaTesser TahaTesser force-pushed the checkboxlisttile_active_color_theme branch from 0fa7853 to f3d12f3 Compare February 25, 2022 11:50
@TahaTesser TahaTesser mentioned this pull request Mar 29, 2022
Merged
8 tasks
@TahaTesser
Copy link
Member Author

TahaTesser commented Apr 9, 2022

Closing for #97972

@TahaTesser TahaTesser closed this Apr 9, 2022
@TahaTesser TahaTesser deleted the checkboxlisttile_active_color_theme branch July 21, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TahaTesser