Skip to content

Fix position of CupertinoContextMenu within Transform.scale #97896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 1 commit into from
May 2, 2022
Merged

Fix position of CupertinoContextMenu within Transform.scale #97896

guidezpl merged 1 commit into from
May 2, 2022

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Feb 6, 2022 •
edited
Loading

CupertinoContextMenu does not appear in the right position if there is a Transform.scale at some point in its ancestors.

WidgetController also didn't respect Transform.scale properly, so when adding a test for this fix some other tests needed to be updated to pass.

Fixes #102061

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 6, 2022
@moffatman moffatman force-pushed the contextmenu branch 2 times, most recently from b13dd78 to 138c186 Compare February 7, 2022 21:05
@guidezpl guidezpl merged commit 6ddb99e into flutter:master May 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2022
@engine-flutter-autoroll
6ddb99e Fix position of CupertinoContextMenu within Transform.scale (f…
a01681e 
…lutter/flutter#97896)
darrenaustin added a commit that referenced this pull request May 2, 2022
@darrenaustin
Revert "Fix position of CupertinoContextMenu within Transform.scale (#…
313a4e8 
…97896)"

This reverts commit 6ddb99e.
@darrenaustin darrenaustin mentioned this pull request May 2, 2022
Merged
darrenaustin added a commit that referenced this pull request May 2, 2022
@darrenaustin
Revert "Fix position of CupertinoContextMenu within Transform.scale (#…
7965ee2 
…97896)" (#102938)

This reverts commit 6ddb99e.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 2, 2022
@engine-flutter-autoroll
6ddb99e Fix position of CupertinoContextMenu within Transform.scale (f…
68a63db 
…lutter/flutter#97896)
@guidezpl
Copy link
Member

guidezpl commented May 2, 2022

Reverted, see #102938

moffatman added a commit to moffatman/flutter that referenced this pull request May 2, 2022
@moffatman
Fix position of CupertinoContextMenu within Transform.scale (flutter#…
bb068fd 
…97896)
@moffatman moffatman mentioned this pull request May 2, 2022
Merged
8 tasks
guidezpl pushed a commit that referenced this pull request May 4, 2022
@moffatman
Reland "Fix position of CupertinoContextMenu within Transform.scale" (#…
b5321d1 
…102943)

* Fix position of CupertinoContextMenu within Transform.scale (#97896)

* Fix after rebase
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@moffatman @egramond
Fix position of CupertinoContextMenu within Transform.scale (flutter#…
6dca47f 
…97896)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@darrenaustin @egramond
Revert "Fix position of CupertinoContextMenu within Transform.scale (f…
bb1d06f 
…lutter#97896)" (flutter#102938)

This reverts commit 6ddb99e.
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@moffatman @egramond
Reland "Fix position of CupertinoContextMenu within Transform.scale" (f…
15e7ebb 
…lutter#102943)

* Fix position of CupertinoContextMenu within Transform.scale (flutter#97896)

* Fix after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoContextMenu animation is the wrong size when within Transform.scale

2 participants

@moffatman @guidezpl