Skip to content

[framework] don't hit test for system nav bar or system chrome on desktop #97883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Feb 8, 2022
Merged

[framework] don't hit test for system nav bar or system chrome on desktop #97883

fluttergithubbot merged 3 commits into from
Feb 8, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 5, 2022

Redo of #97771 due to git

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 5, 2022
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Feb 5, 2022

This includes a change to completely skip the status bar test on desktop

goderbauer
goderbauer approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test/rendering/view_chrome_style_test.dart Outdated
variant: TargetPlatformVariant.mobile(),
);

testWidgets("statusBarColor isn't on desktop platforms",
Copy link
Member

@goderbauer goderbauer Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: statusBarColor isn't what?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

literally can't even

@fluttergithubbot fluttergithubbot merged commit a7a3d8b into flutter:master Feb 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
d5a7313 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
79fa6c7 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
6a2c06e 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
e59d509 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
c7e3ca1 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
5664982 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
870b9ad 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
351f8c4 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
f431f1f 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
ee8e13a 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
7b4dc17 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
a5bdbb4 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
ae37455 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
ece7896 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
8fa1249 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
d9bd80c 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
86231d6 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
ef16a11 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
721b2df 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
d749f2c 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
a05c7a5 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
b1fe878 
…e on desktop (flutter/flutter#97883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a7a3d8b [framework] don't hit test for system nav bar or system chrom…
f0413a5 
…e on desktop (flutter/flutter#97883)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
[framework] don't hit test for system nav bar or system chrome on des…
7d22c58 
…ktop (flutter#97883)
@Piinks Piinks mentioned this pull request Mar 16, 2022
Closed
@jonahwilliams jonahwilliams deleted the benchy_mc_benchface_2 branch March 17, 2022 00:33
jonahwilliams pushed a commit that referenced this pull request Mar 17, 2022
Revert "[framework] don't hit test for system nav bar or system chrom…
61f0782 
…e on desktop (#97883)"

This reverts commit a7a3d8b.
@jonahwilliams jonahwilliams mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @goderbauer @fluttergithubbot