Skip to content

Add custom size constraints parameter to PopupMenu #97798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 15, 2022
Merged

Add custom size constraints parameter to PopupMenu #97798

fluttergithubbot merged 2 commits into from
Feb 15, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 4, 2022 •
edited
Loading

fixes #64918

This provides a way to control popup menu size constraints similar to IconButton's constraints parameter

This is particularly useful when a user doesn't wanna get constrained by the default values and want to make the popup menu as wide as possible.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 4, 2022
gspencergoog
gspencergoog approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@TahaTesser TahaTesser force-pushed the popupmenu_size_constraints branch from 794a7a4 to 3b66c79 Compare February 14, 2022 23:37
@TahaTesser TahaTesser changed the title Add custom size constraints to PopupMenu Add custom size constraints parameter to PopupMenu Feb 14, 2022
@fluttergithubbot fluttergithubbot merged commit ccaf515 into flutter:master Feb 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
ccaf515 Add custom size constraints parameter to PopupMenu (flutter…
ecdf92d 
…/flutter#97798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
ccaf515 Add custom size constraints parameter to PopupMenu (flutter…
3ad700d 
…/flutter#97798)
@TahaTesser TahaTesser deleted the popupmenu_size_constraints branch February 15, 2022 07:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
ccaf515 Add custom size constraints parameter to PopupMenu (flutter…
9fd4db5 
…/flutter#97798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
ccaf515 Add custom size constraints parameter to PopupMenu (flutter…
5f02212 
…/flutter#97798)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
ccaf515 Add custom size constraints parameter to PopupMenu (flutter…
60f8dd5 
…/flutter#97798)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Add custom size constraints parameter to PopupMenu (flutter#97798)
55f3c74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow PopupMenuItem's width to be set to full width of the screen

3 participants

@TahaTesser @gspencergoog @fluttergithubbot