[EditableText] honor the "brieflyShowPassword" system setting #97769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
justinmc
reviewed
Feb 4, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
Quick question in the tests where a value was not what I expected. Probably I just didn't follow the test correctly. Otherwise ready to LGTM.
I'm glad we will have this feature now!
| await tester.enterText(find.byType(EditableText), 'AAA'); | ||
| await tester.pump(); | ||
|
|
||
| tester.binding.window.brieflyShowPasswordTestValue = false; |
Contributor
There was a problem hiding this comment.
It's cool that we can easily fake this stuff in tests, I haven't worked much with WidgetsBinding before.
| addTearDown(() { | ||
| tester.binding.window.brieflyShowPasswordTestValue = true; | ||
| }); | ||
| expect((findRenderEditable(tester).text! as TextSpan).text, '••A'); |
Contributor
There was a problem hiding this comment.
Wait why is the final "A" visible if brieflyShowPasswordTestValue is false?
Contributor
Author
There was a problem hiding this comment.
it becomes hidden on the next cursor tick.
| bool get brieflyShowPassword => _brieflyShowPasswordTestValue ?? platformDispatcher.brieflyShowPassword; | ||
| bool? _brieflyShowPasswordTestValue; | ||
| /// Hides the real [brieflyShowPassword] and reports the given | ||
| /// `brieflyShowPassword` instead. |
Contributor
There was a problem hiding this comment.
Nit: Maybe say brieflyShowPasswordTestValue instead of brieflyShowPassword?
Contributor
Author
There was a problem hiding this comment.
Ah right good catch!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
godofredoc
added a commit
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
Contributor
|
This was reverted in #98089 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
LongCatIsLooong
added a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 9, 2022
fluttergithubbot
pushed a commit
that referenced
this pull request
Feb 11, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
…flutter#97769)" (flutter#98089) This reverts commit 63f48d1.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.