Skip to content

Revert "[flutter_tool] Download gen_snapshot.zip for macOS desktop (#97627) #97664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Feb 2, 2022
Merged

Revert "[flutter_tool] Download gen_snapshot.zip for macOS desktop (#97627) #97664

zanderso merged 1 commit into from
Feb 2, 2022

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Feb 2, 2022

This reverts commit 32abf42.

Broke a conductor test that checks the codesigning process.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 2, 2022
@zanderso
Copy link
Member Author

zanderso commented Feb 2, 2022

Landing near tip-of-tree revert eagerly to open the tree.

@zanderso zanderso merged commit f82c020 into master Feb 2, 2022
@zanderso zanderso deleted the revert-97627-pull-gen-snapshots branch February 2, 2022 19:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
f82c020 Revert "[flutter_tool] Download gen_snapshot.zip for macOS de…
5eaaa32 
…sktop (#97627)" (flutter/flutter#97664)
@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 2, 2022

Hmm, interesting, it looks like the mac test doesn't run pre-submit (thus why this wasn't caught)?

@zanderso
Copy link
Member Author

zanderso commented Feb 2, 2022

Yeah. Presubmit was green.

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 2, 2022

Nope, actually it looks like an over-specific runIf field

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 2, 2022

https://github.com/flutter/flutter/blob/master/.ci.yaml#L2515

    runIf:
      - dev/**
      - packages/flutter/**
      - packages/flutter_driver/**
      - packages/integration_test/**
      - packages/flutter_localizations/**
      - packages/fuchsia_remote_debug_protocol/**
      - packages/flutter_test/**
      - packages/flutter_goldens/**
      - packages/flutter_tools/lib/src/test/**
      - bin/**
      - .ci.yaml

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
f82c020 Revert "[flutter_tool] Download gen_snapshot.zip for macOS de…
6d6f8ee 
…sktop (#97627)" (flutter/flutter#97664)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
f82c020 Revert "[flutter_tool] Download gen_snapshot.zip for macOS de…
7175875 
…sktop (#97627)" (flutter/flutter#97664)
This was referenced Feb 2, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
f82c020 Revert "[flutter_tool] Download gen_snapshot.zip for macOS de…
6be7057 
…sktop (#97627)" (flutter/flutter#97664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
f82c020 Revert "[flutter_tool] Download gen_snapshot.zip for macOS de…
63f6b2f 
…sktop (#97627)" (flutter/flutter#97664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
f82c020 Revert "[flutter_tool] Download gen_snapshot.zip for macOS de…
39bf223 
…sktop (#97627)" (flutter/flutter#97664)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@zanderso @clocksmith
Revert "[flutter_tool] Download gen_snapshot.zip for macOS desktop (f…
009ce91 
…lutter#97627)" (flutter#97664)

This reverts commit 32abf42.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @christopherfujino