Update comments for chip tests #97476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
goderbauer
reviewed
Feb 5, 2022
Member
There was a problem hiding this comment.
Why do you want to change this test?
Contributor
Author
There was a problem hiding this comment.
The following(3 or 4) tests have almost similar flow to test the same functionality, so this change is to make all tests have similar code.
Member
There was a problem hiding this comment.
This is reducing our test coverage, though. The chip needs to support both modes of interaction: pressing and holding as well as hovering - and we should check for both.
Contributor
Author
There was a problem hiding this comment.
Okay, I'll revert the change.
royarg02
force-pushed
the
update_chip_tests
branch
from
3fd01c6 to
0e28579
Compare
royarg02
force-pushed
the
update_chip_tests
branch
from
0e28579 to
7880dd0
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 23, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some comments of tests for the
Chipwidgets.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.