Skip to content

Make the application lifecycle does not affect SchedulerBinding.scheduleForcedFrame. #97468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 5, 2022
Merged

Make the application lifecycle does not affect SchedulerBinding.scheduleForcedFrame. #97468

fluttergithubbot merged 2 commits into from
Feb 5, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Jan 29, 2022 •
edited
Loading

Make the Application lifecycle does not affect SchedulerBinding.scheduleForcedFrame.

fixes #97473

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 29, 2022
@ColdPaleLight ColdPaleLight force-pushed the fix_schedule_forced_frame branch from 50c79d2 to 13e04c9 Compare January 29, 2022 04:42
@ColdPaleLight ColdPaleLight changed the title Make 'scheduleForcedFrame' behave correctly Make the application lifecycle does not affect SchedulerBinding.scheduleForcedFrame. Jan 29, 2022
@ColdPaleLight ColdPaleLight requested a review from Hixie February 3, 2022 05:24
@HansMuller HansMuller requested a review from cbracken February 4, 2022 22:57
chunhtai
chunhtai approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@fluttergithubbot fluttergithubbot merged commit 1cb912e into flutter:master Feb 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
b3ec9c6 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
1cd891b 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
497c75f 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
3f938a8 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
7c63d44 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
a637c39 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
059c668 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
064ad2d 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
8723e3b 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
a6bcb65 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
3976c0e 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
3cf4f8b 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
7dcff8a 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
2184d34 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
e78f34d 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
e4e78e6 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
faa7e21 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
4acb82f 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
862eeb4 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
9d562f6 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
7eadcbd 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
81fbfdf 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
1cb912e Make the application lifecycle does not affect `SchedulerBind…
7511fd3 
…ing.scheduleForcedFrame`. (flutter/flutter#97468)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@ColdPaleLight @clocksmith
Make the application lifecycle does not affect `SchedulerBinding.sche…
4fc7319 
…duleForcedFrame`. (flutter#97468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@Hixie Hixie Awaiting requested review from Hixie

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SchedulerBinding.scheduleForcedFrame currently behaves differently than it was originally designed

3 participants

@ColdPaleLight @chunhtai @fluttergithubbot