Implement system menu bar support #97408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
gspencergoog
force-pushed
the
menu_bar
branch
2 times, most recently
from
e348136 to
ee1b4f2
Compare
gspencergoog
force-pushed
the
menu_bar
branch
12 times, most recently
from
3e8f18b to
3dd2c1a
Compare
gspencergoog
force-pushed
the
menu_bar
branch
5 times, most recently
from
1331e21 to
ccac0ae
Compare
18 tasks
gspencergoog
force-pushed
the
menu_bar
branch
from
ccac0ae to
008946d
Compare
gspencergoog
force-pushed
the
menu_bar
branch
from
28346db to
05b59ea
Compare
|
Gold has detected about 38 new digest(s) on patchset 15. |
gspencergoog
force-pushed
the
menu_bar
branch
2 times, most recently
from
bf221e8 to
064e773
Compare
gspencergoog
force-pushed
the
menu_bar
branch
2 times, most recently
from
ebda9e5 to
ec20ae6
Compare
flutter-dashboard
bot
added
the
f: gestures
gspencergoog
force-pushed
the
menu_bar
branch
8 times, most recently
from
da3754e to
ee5006b
Compare
gspencergoog
force-pushed
the
menu_bar
branch
14 times, most recently
from
a799de7 to
aa6ec6e
Compare
Contributor
Author
|
Closing this to start a new one without all the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a prototype of
MenuBarwidgets that can both render a Material menu bar, and speak to a bundled plugin on the engine that will create and manage system generated menu bars on macOS, Windows, and Linux (a.k.a.PlatformMenuBar, submitted already).This implementation of the
MenuBaruses aMenuBarControllerto manager most of the communincation between widgets that need to occur to implement the menu bar. TheMenuBaruses a hierarchy ofMenuBarItemwidgets which extendMenuItemso that they are also useful for configuring a platform provided menu.For the Material
MenuBar,MenuBarItemwidgets have an internal_MenuNodeassigned by looking for a wrapping_MenuNodeWrapper, and then they register attributes with that node (things like the focus node associated with the button, and the menu builder function for the submenus).Related Issues
Tests
MenuBaroperations and configuration.Design Doc