Skip to content

Draggable can be accepted when the data is null #97355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 23, 2022
Merged

Draggable can be accepted when the data is null #97355

fluttergithubbot merged 2 commits into from
Feb 23, 2022

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Jan 27, 2022

Fixes #84816

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 27, 2022
@HansMuller HansMuller requested a review from Piinks January 28, 2022 22:37
Piinks
Piinks reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks for the fix. I am running this through G testing, I think it will be fine, but just in case I want to be sure this won't break and get reverted.

@Piinks
Copy link
Contributor

Piinks commented Feb 18, 2022

@xu-baolin can you update this PR with the latest from master? The Google testing shard had some issues, and I cannot see if the failures are legit here. Thanks!

@skia-gold
Copy link

skia-gold commented Feb 18, 2022

Gold has detected about 38 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/97355

Piinks
Piinks approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@fluttergithubbot fluttergithubbot merged commit 2ad0ac0 into flutter:master Feb 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
0e69ca7 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
538d05d 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
60e69da 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
9d17841 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
e79e958 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
aa371fd 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
5dda28f 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
eee4429 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
e7a6c27 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
42ccba2 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
75b31ff 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
8f740c9 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
f9fec3c 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
02fd3c7 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
2a6fc5c 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
19b6c0f 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
ddb08f8 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
6c83827 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
875134d 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
5d26eeb 
…ter#97355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
fed5268 
…ter#97355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
e8d5148 
…ter#97355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
2ad0ac0 Draggable can be accepted when the data is null (flutter/flut…
9e45fb4 
…ter#97355)
Piinks added a commit that referenced this pull request Mar 2, 2022
@Piinks
Revert "Draggable can be accepted when the data is null (#97355)"
2a9fd4d 
This reverts commit 2ad0ac0.
@Piinks Piinks mentioned this pull request Mar 2, 2022
Merged
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@xu-baolin @clocksmith
Draggable can be accepted when the data is null (flutter#97355)
64c3d3d
@TahaTesser TahaTesser mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DragTarget crash if Draggable data field is not set, but data is not required.

5 participants

@xu-baolin @Piinks @skia-gold @goderbauer @fluttergithubbot