Skip to content

Disallow flutter run-ing on 32-bit development devices #97339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 12, 2022
Merged

Disallow flutter run-ing on 32-bit development devices #97339

fluttergithubbot merged 1 commit into from
Apr 12, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 27, 2022 •
edited
Loading

32-bit iOS tests have been removed from the devicelab: #97148.

Fixes #97329.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 27, 2022
@jmagman jmagman self-assigned this Jan 27, 2022
@jmagman jmagman mentioned this pull request Jan 27, 2022
Merged
8 tasks
@jmagman jmagman marked this pull request as ready for review February 8, 2022 01:02
@jmagman jmagman requested a review from zanderso February 8, 2022 01:02
@jmagman
Copy link
Member Author

jmagman commented Feb 8, 2022

Hmm I guess this needs to wait a few months...?

To clarify, after the 2.10 stable cycle, we can stop testing on 32-bit iOS on Flutter's CI. However, it's only after the branch cut for the Q2 stable (probably 2.13) that we'll be able to remove support completely.

#97329 (comment)

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 17, 2022

#97329

I will mark this as draft then

@christopherfujino christopherfujino marked this pull request as draft February 17, 2022 22:19
@jmagman jmagman marked this pull request as ready for review April 7, 2022 01:43
@jmagman jmagman force-pushed the unsupported-32-device branch from 948e3ce to 9b6444d Compare April 7, 2022 02:08
@jmagman jmagman force-pushed the unsupported-32-device branch from 9b6444d to 7cce7eb Compare April 8, 2022 00:52
@jmagman
Copy link
Member Author

jmagman commented Apr 8, 2022

This is ready for review!

christopherfujino
christopherfujino reviewed Apr 8, 2022
View reviewed changes
packages/flutter_tools/lib/src/ios/devices.dart
@override
bool isSupported() => true;
// 32-bit devices are not supported.
bool isSupported() => cpuArchitecture == DarwinArch.arm64;
Copy link
Contributor

@christopherfujino christopherfujino Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this never get called with cpuArchitecture == x64 on simulators?

Copy link
Member Author

@jmagman jmagman Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is in IOSDevice which is for physical devices. Simulators are handled here:

flutter/packages/flutter_tools/lib/src/ios/simulators.dart

Line 405 in 3109073

bool isSupported() {

@jmagman
Copy link
Member Author

jmagman commented Apr 8, 2022

Waiting for @zanderso to say go post branch alignment.

christopherfujino
christopherfujino approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member

zanderso commented Apr 9, 2022

Being a little over cautious: As soon as the current g3 roll lands and sticks we can start on this.

zanderso
zanderso approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safe to land, and overall we're safe to proceed with removing support.

@fluttergithubbot fluttergithubbot merged commit 888208c into flutter:master Apr 12, 2022
@jmagman jmagman deleted the unsupported-32-device branch April 12, 2022 21:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
888208c Disallow flutter run-ing on 32-bit development devices (flu…
df3cada 
…tter/flutter#97339)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
888208c Disallow flutter run-ing on 32-bit development devices (flu…
690d4fc 
…tter/flutter#97339)
@jmagman jmagman mentioned this pull request Jun 6, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disallow flutter run-ing on 32-bit development devices

4 participants

@jmagman @christopherfujino @zanderso @fluttergithubbot