Skip to content

Do not crash if dispatch the mouse events before the tooltip overlay detached #97268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 25, 2022
Merged

Do not crash if dispatch the mouse events before the tooltip overlay detached #97268

fluttergithubbot merged 1 commit into from
Feb 25, 2022

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Jan 26, 2022

Fixes #96890

The Tooltip widget and the tip overlay are detached in different frames.
We should ignore the mouse events if the Tooltip is detached.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 26, 2022
@xu-baolin xu-baolin requested a review from Piinks January 27, 2022 00:56
@xu-baolin
Copy link
Member Author

xu-baolin commented Feb 24, 2022

CC @Piinks : )

Piinks
Piinks approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you - apologies for missing this one!

Flutter_LGTM

@Piinks Piinks added a: mouse Issues related to using a mouse or mouse support c: crash Stack traces logged to the console waiting for tree to go green labels Feb 24, 2022
@fluttergithubbot fluttergithubbot merged commit 839bd63 into flutter:master Feb 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
102652c 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
0321180 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
012363d 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
abdb7e2 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
9ab73f9 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
24b488b 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
5b92a1b 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
3619003 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
f4b0c9f 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
aba2df7 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
20419e9 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
8263f70 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
4ff062c 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
fccdeef 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
8901365 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
9f7a316 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
37522ed 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
ec640cb 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
510e335 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
895ca3c 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
57c3dce 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
44c3e37 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
202ad4a 
…overlay detached (flutter/flutter#97268)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
839bd63 Do not crash if dispatch the mouse events before the tooltip …
d892b92 
…overlay detached (flutter/flutter#97268)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@xu-baolin @clocksmith
Do not crash if dispatch the mouse events before the tooltip overlay …
346cbc4 
…detached (flutter#97268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: mouse Issues related to using a mouse or mouse support c: crash Stack traces logged to the console f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Tooltip widget lack of correct state management?

3 participants

@xu-baolin @Piinks @fluttergithubbot