Adjust lipo thinning input/output for macOS #97111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
zanderso
force-pushed
the
fix-lip-thinning-output
branch
from
f8375e6 to
bd4ed4d
Compare
jmagman
approved these changes
Jan 24, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
The lipo thinning was never exercised before multiple archs existed. LGTM!
Member
|
Thanks! |
10 tasks
Member
|
x-ref Part of #69221 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 4, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code signing gets confused if the target is a fat binary in the top-level directory in a framework. This change preserves the symlink structure of the copied framework by applying lipo thinning to the underlying binary.
Without this, I get the following during code signing with a fat binary that includes x64 and arm64: