Skip to content

Conversation

@ansolantz
Copy link

The Cupertino date picker does not work correctly when using minuteInterval and scrolling past the endDate

List which issues are fixed by this PR. You must list at least one issue.
Issue 97010

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jan 21, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@SuhwanCha
Copy link
Contributor

Hi, @ansolantz
You should write tests code or request to be approved.
Please follow link below: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests

@ansolantz
Copy link
Author

Hi, @ansolantz You should write tests code or request to be approved. Please follow link below: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests

Hi @SuhwanCha,
I honestly do not know how to write a test case for this, and since the solution is pretty straightforward I prefer to wait for the ticket to be answered.

@Hixie
Copy link
Contributor

Hixie commented Apr 5, 2022

@ansolantz that fix is probably correct (i honestly don't know the code well enough to say for sure) but @SuhwanCha is right, before we can review it it really needs a test. You can find the other datepicker tests here: https://github.com/flutter/flutter/blob/master/packages/flutter/test/cupertino/date_picker_test.dart

@Hixie
Copy link
Contributor

Hixie commented May 31, 2022

Thanks for the contribution! I'm going to close this PR since it needs tests, as per the comments above. If anyone wants to take over please don't hesitate to take this code and submit a new PR!

@Hixie Hixie closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants