CupertinoTabBar: Add clickable cursor on web #96996

TahaTesser · 2022-01-21T12:03:26Z

partial fix for #86174

Integration test for web results:

CupertinoTabBar

Launching integration_test/cupertino/cupertino_tab_bar.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_tab_bar.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:55352/htWEd61mxMk=/ws
Debug service listening on ws://127.0.0.1:55352/htWEd61mxMk=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:55352/htWEd61mxMk=/ws
00:00 +0: Hovering over tab bar item updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Renzo-Olivares

Similar to my review on CupertinoButton. A test for when the cursor is not hovering on top of the button would be good.

packages/flutter/test/cupertino/bottom_tab_bar_test.dart

Remove trailing space Kick tests Update test

TahaTesser · 2022-03-03T23:08:35Z

@Renzo-Olivares
Thanks so much for the review, appreciate it!

I intend to make similar changes to other Cupertino widgets ASAP. I wanted to some confirmation with these two current PRs.

TahaTesser · 2022-03-04T13:21:08Z

@Renzo-Olivares
Actually tested the test on the web using integration_test, it works as expected after updating the test, results in the description.

Renzo-Olivares

LGTM!

…#96996)

flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jan 21, 2022

TahaTesser mentioned this pull request Jan 21, 2022

Cupertino widgets don't change mouse cursor when hover on web #86174

Closed

Renzo-Olivares reviewed Mar 2, 2022

View reviewed changes

Renzo-Olivares self-assigned this Mar 2, 2022

TahaTesser force-pushed the cupertinotabbar_web_cursor branch from 8cc0ebe to b8bc08f Compare March 3, 2022 09:25

Renzo-Olivares requested changes Mar 3, 2022

View reviewed changes

packages/flutter/test/cupertino/bottom_tab_bar_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/cupertino/bottom_tab_bar_test.dart Outdated Show resolved Hide resolved

TahaTesser added 2 commits March 4, 2022 01:06

CupertinoTabBar: Add clickable cursor on web

10ecf6a

Remove trailing space Kick tests Update test

Update test

708741a

TahaTesser force-pushed the cupertinotabbar_web_cursor branch from b8bc08f to 708741a Compare March 3, 2022 23:06

TahaTesser requested a review from Renzo-Olivares March 3, 2022 23:08

TahaTesser added 2 commits March 4, 2022 01:10

fix title

7f194fc

Update test

e1e03c1

Renzo-Olivares approved these changes Mar 7, 2022

View reviewed changes

TahaTesser added the waiting for tree to go green label Mar 7, 2022

fluttergithubbot merged commit 4f7d7b5 into flutter:master Mar 7, 2022

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from a491a81f7873 to 4f7d7b56191d (2 revisions) flutter/plugins#5015

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 7, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

8b8681a

…#96996)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 4f7d7b56191d (85 revisions) flutter/packages#1110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

c34d6c0

…#96996)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 4c591bc755c4 (86 revisions) flutter/packages#1111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

182682d

…#96996)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 10805ca3fe6b (87 revisions) flutter/packages#1112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

77c6e61

…#96996)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from a491a81f7873 to 10805ca3fe6b (4 revisions) flutter/plugins#5016

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 7, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

76d876d

…#96996)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 8f58af8b8ce9 (88 revisions) flutter/packages#1113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

0b803ae

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

b234bea

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

fba9b8d

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

a414d8f

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

dff2ec3

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

70a4cb6

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

4a84deb

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

c2d108b

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

abcb32a

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

0aef34f

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

fffcf90

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

adefb9c

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

a987c06

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

4914451

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

5d00a23

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

99dab70

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

548c995

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

d17337f

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

7b9a72d

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

4df8e16

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

13f96fe

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

04eb71e

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

bb0bcfe

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

72073b2

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

2051431

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

48f1f3e

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

b130318

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

478f661

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

afc594f

…#96996)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…

a168961

…#96996)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CupertinoTabBar: Add clickable cursor on web #96996

CupertinoTabBar: Add clickable cursor on web #96996

Uh oh!

TahaTesser commented Jan 21, 2022 •

edited

Loading

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Uh oh!

Uh oh!

TahaTesser commented Mar 3, 2022

Uh oh!

TahaTesser commented Mar 4, 2022 •

edited

Loading

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CupertinoTabBar: Add clickable cursor on web #96996

CupertinoTabBar: Add clickable cursor on web #96996

Uh oh!

Conversation

TahaTesser commented Jan 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Integration test for web results: