Skip to content

Deprecate Scrollbar isAlwaysShown -> thumbVisibility #96957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 9 commits into from
Jan 24, 2022
Merged

Deprecate Scrollbar isAlwaysShown -> thumbVisibility #96957

fluttergithubbot merged 9 commits into from
Jan 24, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jan 20, 2022 •
edited
Loading

Part one of several scrollbar clean up PRs to prepare for desktop scrollbars.
Original PR was #96935, but it was becoming too large
Tracking the progress overall in #96936

This PR handles the addition of thumbVisibility and deprecates isAlwaysShown.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. f: scrolling Viewports, list views, slivers, etc. a: desktop Running on desktop c: tech-debt Technical debt, code quality, testing, etc. labels Jan 20, 2022
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 20, 2022
@Piinks Piinks mentioned this pull request Jan 20, 2022
Closed
5 tasks
@Piinks Piinks changed the title Scrollbar dep1 Deprecate Scrollbar isAlwaysShown -> thumbVisibility Jan 20, 2022
@goderbauer
Copy link
Member

goderbauer commented Jan 20, 2022

The analyzer is unhappy :)

@Piinks
Copy link
Contributor Author

Piinks commented Jan 20, 2022

The analyzer is unhappy :)

Bah sorry, fixed now. I think.

xu-baolin
xu-baolin reviewed Jan 21, 2022
View reviewed changes
xu-baolin
xu-baolin reviewed Jan 21, 2022
View reviewed changes
@Piinks Piinks requested a review from xu-baolin January 21, 2022 19:00
xu-baolin
xu-baolin approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@xu-baolin xu-baolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nits

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 24, 2022

This pull request is not suitable for automatic merging in its current state.

@flutter-dashboard flutter-dashboard bot added the d: api docs Issues with https://api.flutter.dev/ label Jan 24, 2022
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos documentation labels Jan 24, 2022
@Piinks Piinks added waiting for tree to go green c: new feature Nothing broken; request for a new capability labels Jan 24, 2022
@fluttergithubbot fluttergithubbot merged commit 03da339 into flutter:master Jan 24, 2022
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Jan 25, 2022
@darshankawar darshankawar mentioned this pull request Jan 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
03da339 Deprecate Scrollbar isAlwaysShown -> thumbVisibility (flutter…
0ef5fb1 
…/flutter#96957)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Piinks @clocksmith
Deprecate Scrollbar isAlwaysShown -> thumbVisibility (flutter#96957)
adef8dc
@Piinks Piinks mentioned this pull request May 22, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Jun 5, 2023
@Piinks
Remove scrollbar deprecations isAlwaysShown and hoverThickness (#127351)
a3ddead 
The deprecated `[RawScrollbar/Scrollbar/CupertinoScrollbar/ScrollbarThemeData].isAlwaysShown` has expired and is removed in thi PR.
Also, `Scrollbar.hoverThickness` is also removed after having expired.

The replacement for `isAlwaysShown` is `thumbVisibility`. This deprecation was introduced in #96957. The name change came from new behaviors like a track that is conditionally visible. Since the original API only referred to the thumb, the name was changed to reflect this intention. This change is supported by dart fix. � 

The replacement for `hoverThickness` is `ScrollbarThemeData.thickness`, which is a MaterialStateProperty that allows for the thickness to respond to multiple states including hover. This deprecation was introduced in #97173. This change is not supported by dart fix. �  

Part of #127042
@JishnuM JishnuM mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xu-baolin xu-baolin xu-baolin approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: desktop Running on desktop c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: new feature Nothing broken; request for a new capability c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @goderbauer @fluttergithubbot @xu-baolin