Skip to content

[WIP] Support iOS Premotion refresh rate #96710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luckysmg wants to merge 8 commits into from
Closed

[WIP] Support iOS Premotion refresh rate #96710

luckysmg wants to merge 8 commits into from

Conversation

@luckysmg
Copy link
Contributor

@luckysmg luckysmg commented Jan 16, 2022 •
edited
Loading

Demo repo:https://github.com/luckysmg/flutter_frame_rate_demo

This solution is functionally feasible, but needs further discussion with the flutter team

flutter engine PR:flutter/engine#30900

List which issues are fixed by this PR. You must list at least one issue.
#90675

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jan 16, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 16, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@luckysmg luckysmg mentioned this pull request Jan 16, 2022
Closed
8 tasks
@luckysmg luckysmg marked this pull request as draft January 16, 2022 02:53
@luckysmg luckysmg changed the title Support iOS Premotion refresh rates Support iOS Premotion refresh rate Jan 16, 2022
@luckysmg luckysmg mentioned this pull request Jan 18, 2022
Merged
8 tasks
@acoutts acoutts mentioned this pull request Jan 21, 2022
Closed
@luckysmg luckysmg changed the title Support iOS Premotion refresh rate [WIP] Support iOS Premotion refresh rate Jan 23, 2022
@Hixie
Copy link
Contributor

Hixie commented Mar 29, 2022

I'm going to close this PR since it's not intended for review as far as I can tell, but I encourage you to have whatever discussion is needed on the relevant issue (as cited in the original comments above). Thanks!

@Hixie Hixie closed this Mar 29, 2022
@luckysmg luckysmg deleted the frame_rate_framework branch August 29, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: animation Animation APIs f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luckysmg @Hixie