Document remaining non-scrolling symbols #9667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Apr 28, 2017
Contributor
There was a problem hiding this comment.
btw we should consider replacing this with a selector that doesn't need a tab controller and just reads out the page information from the nearest PageView.
Hixie
reviewed
Apr 28, 2017
Hixie
reviewed
Apr 28, 2017
Contributor
There was a problem hiding this comment.
we should say here that it throws when the ticker is canceled
Hixie
reviewed
Apr 28, 2017
Contributor
|
|
This patch finishes documenting all the symbols except for those related to scrolling.
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch finishes documenting all the symbols except for those related to
scrolling.