Skip to content

[WIP] Spell Check for Android Proof of Concept #96629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camsim99 wants to merge 99 commits into from
Closed

[WIP] Spell Check for Android Proof of Concept #96629

camsim99 wants to merge 99 commits into from

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jan 13, 2022 •
edited
Loading

WIP. Intended to be a POC for Issue #34688 for Android.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 13, 2022
camsim99 added 23 commits January 28, 2022 16:39
@camsim99
Started filling in todos
bb5e12a
@camsim99
Fill in more holes
c9f661c
@camsim99
Add update
34a7ff3
@camsim99
Merge remote-tracking branch 'upstream/master' into issue_34688_dev
d0b154f
@camsim99
Removed editable_text due to inconsistencies
beeab26
@camsim99
Remove editable_text due to inconsistencies
b3a9d01
@camsim99
Add back removed logic
4333fa7
@camsim99
Start fixes
644d048
@camsim99
Building text spans
4f0b492
@camsim99
Corrected building text spans, adds comments for show toolbar
46102b9
@camsim99
Fix style
acc5576
@camsim99
Fix invalid range problem
4658514
@camsim99
Unblock cursor from moving
a90d43d
@camsim99
Make show spell check work through midpoint
7cf0020
@camsim99
Started debugging text height
e528056
@camsim99
Fix text jump
5aab343
@camsim99
Add rest of fix
6643f5c
@camsim99
Clean up comments, fix space issue
91759ee
@camsim99
Remove some more comments
58d00ce
@camsim99
Get toolbar showing flakily
7e4d36c
@camsim99
Make toolbar work with two taps
9f9f363
@camsim99
Remove unused method
9dd8fbb
@camsim99
Make toolbar show on first tap
24e0eaf
@camsim99 camsim99 mentioned this pull request May 25, 2022
Closed
8 tasks
@camsim99 camsim99 closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc left review comments

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camsim99 @justinmc