It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@darrenaustin PTAL :)

test-exempt: code refactor with no semantic change

(that said, if the code is more reusable now, you might want to add a test to verify that reusing it works, because otherwise someone might make it less reusable)

(that said, if the code is more reusable now, you might want to add a test to verify that reusing it works, because otherwise someone might make it less reusable)

I will add test once I made it public, it is not testable now since it is private. The reason I have not made it public now is that the API may change until I finalize the global selection pr. So I rather keep it private and embrace the fact that people may accidentally make it less reusable

seems reasonable