Skip to content

Add Supported devices to the TapGestureRecognizer #96560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunhtai merged 1 commit into from
Jan 13, 2022
Merged

Add Supported devices to the TapGestureRecognizer #96560

chunhtai merged 1 commit into from
Jan 13, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jan 12, 2022 •
edited
Loading

Fixes #96556

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 12, 2022
@chunhtai chunhtai requested a review from dkwingsmt January 12, 2022 23:30
dkwingsmt
dkwingsmt approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 13, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux build_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 13, 2022

This pull request is not suitable for automatic merging in its current state.

@chunhtai chunhtai merged commit e912b91 into flutter:master Jan 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
e912b91 Add Supported devices to the TapGestureRecognizer (flutter/fl…
073bb08 
…utter#96560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
e912b91 Add Supported devices to the TapGestureRecognizer (flutter/fl…
7076c29 
…utter#96560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
@engine-flutter-autoroll
e912b91 Add Supported devices to the TapGestureRecognizer (flutter/fl…
f38c504 
…utter#96560)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
e912b91 Add Supported devices to the TapGestureRecognizer (flutter/fl…
3340d9f 
…utter#96560)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@chunhtai @clocksmith
Add Supported devices to the TapGestureRecognizer (flutter#96560)
debbe22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BaseTapGestureRecognizer and TapGestureRecognizer should be able to set supported devices

3 participants

@chunhtai @fluttergithubbot @dkwingsmt