Text selection located wrong position when selecting multiple lines over max lines #96471
Conversation
flutter-dashboard
bot
added
a: text input
|
Gold has detected about 2 new digest(s) on patchset 2. |
|
Gold has detected about 2 new digest(s) on patchset 3. |
|
cc @justinmc for one more approval |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
This doesn't seem to work in every case. I tried it when the field is vertically centered in the app and the toolbar shows up in the wrong place:
Code
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({
Key? key,
}) : super(key: key);
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: Scaffold(
appBar: AppBar(
title: const Text('Flutter Demo'),
),
body: const Center(
child: TextField(
maxLines: 2,
),
),
),
);
}
}Unfortunately our existing tests didn't catch that.
|
@SuhwanCha I'm going to close this since it's been stale for awhile and has merge conflicts. If you still want to fix this bug, feel free to let me know and I'm happy to help with reviews. |
4 participants
Fixes #96453
This PR fixes bugs that text selection located wrong position when selecting multiple lines over max lines.
Pre-launch Checklist
///).