Skip to content

Conversation

@AlexV525
Copy link
Member

Reland #82670 , fix #43277 . /cc @HansMuller @Hixie

Breaking change note: flutter/website#6646.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AlexV525 AlexV525 requested review from HansMuller and Hixie January 10, 2022 02:26
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 10, 2022
@AlexV525 AlexV525 force-pushed the zoom-page-transition-by-default branch from b636e7a to d5c9605 Compare January 10, 2022 04:49
@AlexV525 AlexV525 marked this pull request as ready for review January 11, 2022 02:42
@AlexV525
Copy link
Member Author

I found that the LisencePage use FadeUpwardsPageTransitionsBuilder explicitly. It should be addressed in new PR though.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Feb 2, 2022

Here's the PR in question: #96375. (Still open, as of 2/2/2022.)

@AlexV525 AlexV525 force-pushed the zoom-page-transition-by-default branch 2 times, most recently from c284329 to 2b4211d Compare February 3, 2022 02:42
@dnfield
Copy link
Contributor

dnfield commented Feb 15, 2022

@renyou it seems like FRoB didn't actually run this PR, but Google testing is green...

@dnfield
Copy link
Contributor

dnfield commented Feb 15, 2022

(I'm doing a manual frob roll of this right now)

@dnfield
Copy link
Contributor

dnfield commented Feb 15, 2022

(Don't mind me, I'm trying to get this into a state where it will more cleanly test internally...)

@skia-gold
Copy link

Gold has detected about 38 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/96375

@AlexV525 AlexV525 force-pushed the zoom-page-transition-by-default branch from f2d92b0 to 812e8c3 Compare February 16, 2022 01:52
@AlexV525 AlexV525 force-pushed the zoom-page-transition-by-default branch from 812e8c3 to 2e2b3da Compare February 16, 2022 01:53
@AlexV525 AlexV525 closed this Feb 16, 2022
@AlexV525 AlexV525 mentioned this pull request Feb 16, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Android 10 Activity Animation the default animation

6 participants