Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jan 7, 2022

Reverts #96244

@zanderso zanderso requested a review from gspencergoog January 7, 2022 02:34
@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Jan 7, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog merged commit dd4db87 into master Jan 7, 2022
@gspencergoog gspencergoog deleted the revert-96244-flutter-engine-flutter-autoroll-52ccb1fc-08d4-4919-98e8-be7aed45a855-1641507583 branch January 7, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants