Skip to content

Conversation

@royarg02
Copy link
Contributor

@royarg02 royarg02 commented Jan 5, 2022

This PR deprecates useDeleteButtonTooltip, for Chip widgets that support having a delete button. This includes the Chip, the InputChip and the RawChip widget.

Instead, to disable the tooltips on the delete button of these chips, users should pass an empty string to deleteButtonTooltipMessage.

A dart fix is provided.

The migration code is shown below:

Before:

Chip(useDeleteButtonTooltip: false);
InputChip(useDeleteButtonTooltip: true);
RawChip rawChip = RawChip();
rawChip.useDeleteButtonTooltip;

After:

Chip(deleteButtonTooltipMessage: ‘’);
InputChip();
RawChip rawChip = RawChip();
rawChip.deleteButtonTooltipMessage;

The design doc for this change can be found here.

This is not a breaking change as it is only deprecating a property.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Jan 5, 2022
royarg02 added a commit to royarg02/website that referenced this pull request Jan 6, 2022
@royarg02 royarg02 changed the title [WIP] Deprecate useDeleteButtonTooltip for Chips Deprecate useDeleteButtonTooltip for Chips Jan 6, 2022
@royarg02
Copy link
Contributor Author

royarg02 commented Jan 6, 2022

@gspencergoog The PR is (mostly) ready for review, I just have a few concerns:
1. Since dev channel is deprecated, what version should I provide for the deprecation notices?
2. I updated some comments and a test for delete button tooltip, which I committed here royarg02@bf86261. If it looks good to you, I'll submit a separate PR.

khanhnwin pushed a commit to flutter/website that referenced this pull request Jan 7, 2022
@HansMuller HansMuller requested a review from Piinks January 7, 2022 23:47
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks for writing a dart fix! 💯
For the deprecation version, update with the latest from the master branch, and then use the version from flutter doctor.

@royarg02 royarg02 force-pushed the deprecate-chip-delete-tooltip branch from 6f6d67c to 7aa9c91 Compare January 22, 2022 04:36
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Jan 26, 2022

Looks like there are some conflicts to resolve before it can land, unfortunately.

@royarg02 royarg02 force-pushed the deprecate-chip-delete-tooltip branch 2 times, most recently from 016e03b to e81a90c Compare January 27, 2022 20:23
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@royarg02 royarg02 force-pushed the deprecate-chip-delete-tooltip branch from e81a90c to 0fb626c Compare January 28, 2022 04:02
@fluttergithubbot fluttergithubbot merged commit 4621dff into flutter:master Jan 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@royarg02 royarg02 deleted the deprecate-chip-delete-tooltip branch March 6, 2022 07:08
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Piinks Piinks mentioned this pull request Sep 12, 2023
8 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 12, 2023
Part of #133171

These deprecations were introduced in #96174
The replacement is to use `deleteButtonTooltipMessage`.
This migration is supported by dart fix. â�
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants