-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Deprecate useDeleteButtonTooltip for Chips
#96174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate useDeleteButtonTooltip for Chips
#96174
Conversation
useDeleteButtonTooltip for ChipsuseDeleteButtonTooltip for Chips
|
@gspencergoog The PR is (mostly) ready for review, I just have a few concerns: |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Thanks for writing a dart fix! 💯
For the deprecation version, update with the latest from the master branch, and then use the version from flutter doctor.
6f6d67c to
7aa9c91
Compare
Hixie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Looks like there are some conflicts to resolve before it can land, unfortunately. |
016e03b to
e81a90c
Compare
|
This pull request is not suitable for automatic merging in its current state.
|
e81a90c to
0fb626c
Compare
This PR deprecates
useDeleteButtonTooltip, forChipwidgets that support having a delete button. This includes theChip, theInputChipand theRawChipwidget.Instead, to disable the tooltips on the delete button of these chips, users should pass an empty string to
deleteButtonTooltipMessage.A dart fix is provided.
The migration code is shown below:
Before:
After:
The design doc for this change can be found here.
This is not a breaking change as it is only deprecating a property.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.