Skip to content

Adds onReorderStart and onReorderEnd arguments to ReorderableList. #96049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 23, 2022
Merged

Adds onReorderStart and onReorderEnd arguments to ReorderableList. #96049

fluttergithubbot merged 2 commits into from
Feb 23, 2022

Conversation

@werainkhatri
Copy link
Member

@werainkhatri werainkhatri commented Jan 3, 2022

Adds onReorderStart and onReorderEnd arguments to SliverReorderableList, ReorderableList, and ReorderableListView.

Fixes #95809

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 3, 2022
@darrenaustin darrenaustin self-requested a review January 7, 2022 22:55
darrenaustin
darrenaustin suggested changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I am not sure I understand the exact use case for this, but it seems like a reasonable API.

Looks nice (and thanks for the tests). Just a few comments/suggestions below.

@skia-gold
Copy link

skia-gold commented Feb 16, 2022

Gold has detected about 31 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/96049

darrenaustin
darrenaustin approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

Thx!

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 23, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 922bbfe into flutter:master Feb 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
922bbfe Adds onReorderStart and onReorderEnd arguments to `Reorde…
809626c 
…rableList`. (flutter/flutter#96049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
922bbfe Adds onReorderStart and onReorderEnd arguments to `Reorde…
5326478 
…rableList`. (flutter/flutter#96049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
922bbfe Adds onReorderStart and onReorderEnd arguments to `Reorde…
ad408d4 
…rableList`. (flutter/flutter#96049)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@werainkhatri @clocksmith
Adds onReorderStart and onReorderEnd arguments to `ReorderableLis…
9199810 
…t`. (flutter#96049)
@Piinks Piinks mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Add "onReorderStart" and "onReorderEnd" event in ReorderableListView class

4 participants

@werainkhatri @skia-gold @fluttergithubbot @darrenaustin