Loosen the constraints for Stack non-positioned children. #9581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #5381 |
abarth
reviewed
Apr 25, 2017
abarth
reviewed
Apr 25, 2017
Contributor
There was a problem hiding this comment.
It would be more efficient if you didn't do this as an override. The default value is just to call through to the super class, so you've made this polymorphic with needing to. Instead, set offstage can call markParentNeedsLayout directly.
Contributor
Author
There was a problem hiding this comment.
I added a markNeedsLayoutForSizedByParentChange method.
Contributor
|
|
Also: * Add three explicit sizing modes to Stack for non-positioned children: loose, expand, and passthrough. (All three are used.) * Fix a bug whereby layers would try to paint in the same frame as they were removed from layout (but not detached). * Fix a bug whereby Offstage wasn't properly marking the parent dirty when changing its sizedByParent flag. * Explicitly make Overlay expand non-positioned children. * Explicitly have InputDecoration pass through the constraints from its Row to its Stack children.
Contributor
Author
|
will check in on green unless i hear otherwise first |
amirh
added a commit
to amirh/flutter
that referenced
this pull request
Jul 1, 2019
``` 45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)" (flutter#9584) fc1d86b Revert "Avoid a full screen overlay within virtual displays (flutter#9343)" (flutter#9581) 140b2ae Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559) 94bb7a7 Adds API for retaining intermediate engine layers (flutter#9461) 7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter#9579) 7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (flutter#9329) ```
amirh
added a commit
that referenced
this pull request
Jul 1, 2019
``` 45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (#9559)" (#9584) fc1d86b Revert "Avoid a full screen overlay within virtual displays (#9343)" (#9581) 140b2ae Roll src/third_party/dart b37aa3b036...1eb113ba27 (#9559) 94bb7a7 Adds API for retaining intermediate engine layers (#9461) 7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (#9579) 7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (#9329) ```
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
``` 45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)" (flutter#9584) fc1d86b Revert "Avoid a full screen overlay within virtual displays (flutter#9343)" (flutter#9581) 140b2ae Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559) 94bb7a7 Adds API for retaining intermediate engine layers (flutter#9461) 7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter#9579) 7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (flutter#9329) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Add three explicit sizing modes to Stack for non-positioned
children: loose, expand, and passthrough. (All three are used.)
Fix a bug whereby layers would try to paint in the same frame as
they were removed from layout (but not detached).
Fix a bug whereby Offstage wasn't properly marking the parent dirty
when changing its sizedByParent flag.
Explicitly make Overlay expand non-positioned children.
Explicitly have InputDecoration pass through the constraints from
its Row to its Stack children.