reads min/target sdk versions from localproperties #95684

brunotacca · 2021-12-22T15:43:23Z

This PR changes the build.gradle files to read the flutter.minSdkVersion and flutter.targetSdkVersion from the generated local.properties, and if not found, keep the default one (which is set at flutter.gradle)

It changes all build.gradle files from examples/* and the integration_test/example.
It doesn't change build.gradle files from dev projects at dev/* but they can be changed too upon further request.
It changes both java and kotlin build.gradle templates.
It changes the default app test to expect the new strings on build.gradle.
It doesn't apply the same concept to flutter.compileSdkVersion, so having it on local.properties doesn't change the value set at flutter.gradle, this can also be added upon further request.

This PR also changes flutter.gradle to detect and warn the developer with a logger.quiet message about mismatches with plugins API level. If a mismatch is found, it also checks if the variables flutter.minSdkVersion and flutter.targetSdkVersion were set at local.properties

It also changes the gradle_errors.dart to update the box message about how to fix the API level error, while adding a reference to the docs. The test was also updated.

Images:

[Before] New project with a dependency requiring higher sdk version.

[After] New project with a dependency requiring higher sdk version.

[After] New project with the variables INcorrectly set at local.properties.

[After] New project with the variables correctly set at local.properties.

It closes #95533
Partially solves #95485 (Android part)
Could be a solution to #95514

Extra - Not related: at 0440790 I fixed the command required to export the FLUTTER_ROOT variable in order to run tests.

meysammahfouzi · 2021-12-26T11:35:15Z

How are the values of flutter.minSdkVersion and flutter.targetSdkVersion initialized at the moment?

brunotacca · 2021-12-26T12:05:06Z

How are the values of `flutter.minSdkVersion` and `flutter.targetSdkVersion` initialized at the moment?

Hello @meysammahfouzi, iirc they are hard coded at flutter.gradle file.

christopherfujino · 2022-01-27T22:15:13Z

@brunotacca this has merge conflicts with upstream, can you rebase or merge in master to resolve before this is reviewed?

brunotacca · 2022-01-27T23:23:44Z

@brunotacca this has merge conflicts with upstream, can you rebase or merge in master to resolve before this is reviewed?

Thank you for notifying me.
There was a conflict with 0e2f51d on packages/flutter_tools/test/commands.shard/permeable/create_test.dart since it changed the same test to verify the build.gradle contents, the ndkVersion flutter.ndkVersion was added.

christopherfujino · 2022-02-10T18:19:47Z

@camsim99 can you (or someone else on the android team) take a look at this PR?

camsim99 · 2022-02-11T18:26:23Z

packages/flutter_tools/templates/app_shared/android-java.tmpl/app/build.gradle.tmpl

Is it something to warn about if the developer doesn't specify it in local.properties? I suppose adding this warning could help with Issue #95514, though. Is that your reasoning?

Same comment for flutterTargetSdkVersion.

Exactly that, it could prevent similar issues in the future. Although, since now there is mention of the local.properties on the flutter website docs, I don't know if it's that necessary anymore.

Oh gotcha! Could we possibly move the warning to flutter.gradle and only show it when not defining it will be a problem, i.e. when the minSdkVersion of a dependency is higher than that of the flutter project?

Certainly, I gonna need a little bit of time to understand how flutter.gradle works but I am on it. Let me get this straight, ideally, what would be the conditions to trigger the custom warning about local.properties?

It seems like if the minSdkVersion of a dependency is greater than that of the mindSdkVersion defined in flutter.gradle, we show the warning so that the person knows how to fix the error that will appear. You can even add a link to your update on the website to the warning for context!

It should be similar to the way we compare the compileSdkVersions of the project and its plugin dependencies right now (see here), but let me know if I can help!

Thank you so much, that should be more than enough for me to get started. I will let you know if I get stuck, thanks!!

@camsim99 Updated the PR description, images. I changed flutter.gradle and also gradle_errors.dart.

Thank you for reviewing.

camsim99

LGTM! Just need to get the tests passing :)

christopherfujino · 2022-02-14T18:30:13Z

To get customer_testing to pass, you will need to rebase (not merge) upstream master.

…utter/engine#31349) (#98142)

…one` (#98028)

…98045)

#98119)

…97769 " (#98150)

…avoid unnecessary layer tree walks (#98219)

This reverts commit 84fcb15.

* Refactor TextSelectionOverlay * fix test * remove print * fix more tests * update * added tests * fix comments * fmt * fix test * addressing comment * remove dispose * remove new line

brunotacca · 2022-02-14T22:53:56Z

@christopherfujino It seems that I did something wrong trying to rebase... Should I close this and make another PR?

christopherfujino · 2022-02-14T22:55:42Z

@christopherfujino It seems that I did something wrong trying to rebase... Should I close this and make another PR?

That works if you are not able to resolve the bad rebase.

brunotacca · 2022-02-14T23:13:05Z

@christopherfujino #98450 I think I did it correctly this time, sorry for the inconvenience.

RatakondalaArun mentioned this pull request Jan 2, 2022

_RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192:12) [BUG] fluttercommunity/flutter_launcher_icons#321

Closed

abrararshad mentioned this pull request Jan 2, 2022

Fixed reading min/target SDK values from local.properties #96039

Closed

christopherfujino added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 27, 2022

christopherfujino added the dependency: android Android team may need to help us label Jan 28, 2022

danagbemava-nc mentioned this pull request Jan 31, 2022

Allow to set minSdkVersion,compileSdkVersion,targetSdkVersion via local.properties #97481

Closed

TahaTesser mentioned this pull request Jan 31, 2022

[Android] build.gradle defaultConfig with local.properties not working properly. #95533

Closed

brunotacca mentioned this pull request Jan 31, 2022

Android deployment - Build configuration addition. flutter/website#6760

Closed

camsim99 self-requested a review February 11, 2022 18:20

camsim99 reviewed Feb 11, 2022

View reviewed changes

brunotacca changed the title ~~reads min/target sdk versions from localproperties~~ [WIP] reads min/target sdk versions from localproperties Feb 11, 2022

brunotacca marked this pull request as draft February 12, 2022 01:57

brunotacca marked this pull request as ready for review February 12, 2022 04:10

brunotacca requested a review from camsim99 February 12, 2022 04:11

brunotacca changed the title ~~[WIP] reads min/target sdk versions from localproperties~~ reads min/target sdk versions from localproperties Feb 12, 2022

danagbemava-nc mentioned this pull request Feb 14, 2022

Add flutter.minSdkVersion to local.properties #98269

Closed

camsim99 approved these changes Feb 14, 2022

View reviewed changes

brunotacca and others added 2 commits February 14, 2022 19:46

reads min/target sdk versions from localproperties

95da50a

Re-land "Support Scribble Handwriting" (#96615) (#96881)

b6baa56

engine-flutter-autoroll and others added 20 commits February 14, 2022 19:46

bed591d Roll Skia from 3e6e29cf2e1b to a424b619bc40 (3 revisions) (fl…

2283744

…utter/engine#31349) (#98142)

[framework] use platform touchslop on Android (#97971)

a19f6c6

Fix NavigationRail Indicator alignment for `NavigationRailLabelType.n…

c9e4f34

…one` (#98028)

Update Material tokens to v0.81. (#98149)

f26272f

Add keyLog and connectionFactory to HttpClient implementations (#…

93a1fa0

…98045)

[flutter_tools] Make variants of Pub have consistent method signatures (

3dc3770

#98119)

Update Xcode version to 13a233 (#98144)

d47e172

Fix flutter gen-l10n help message (#98147)

5b58e2d

Reland "[EditableText] honor the "brieflyShowPassword" system setting #…

161ffe7

…97769 " (#98150)

[integration_test] Fix official example for Android (#98162)

a997a77

[performance] Process dirty nodes from top to bottom during paint to …

e94bf50

…avoid unnecessary layer tree walks (#98219)

Revert "Update Xcode version to 13a233 (#98144)" (#98263)

8424d97

This reverts commit 84fcb15.

Add benchmark to property (#98159)

d67c17e

Support Samsung phone when getting device wakefulness status (#98146)

5dd3e73

Refactor TextSelectionOverlay (#98153)

f945830

* Refactor TextSelectionOverlay * fix test * remove print * fix more tests * update * added tests * fix comments * fmt * fix test * addressing comment * remove dispose * remove new line

[performance] Trace direct calls to inflateWidget (#98277)

f24a9b2

logger message removed from templates

2fe2f07

plugin minSdk check with help msg.

e50fb89

fix gradle_errors to use minSdk local.properties

58bb5fa

fixing command on readme

1d58814

brunotacca requested review from CaseyHillers, Piinks, christopherfujino, jmagman and keyonghan as code owners February 14, 2022 22:50

brunotacca marked this pull request as draft February 14, 2022 22:54

brunotacca closed this Feb 14, 2022

reads min/target sdk versions from localproperties #95684

reads min/target sdk versions from localproperties #95684

Uh oh!

Conversation

brunotacca commented Dec 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meysammahfouzi commented Dec 26, 2021

Uh oh!

brunotacca commented Dec 26, 2021 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jan 27, 2022

Uh oh!

brunotacca commented Jan 27, 2022

Uh oh!

christopherfujino commented Feb 10, 2022

Uh oh!

camsim99 Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

brunotacca Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

camsim99 Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brunotacca Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

camsim99 Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

brunotacca Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

brunotacca Feb 12, 2022

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Feb 14, 2022

Uh oh!

brunotacca commented Feb 14, 2022

Uh oh!

christopherfujino commented Feb 14, 2022

Uh oh!

brunotacca commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

brunotacca commented Dec 22, 2021 •

edited

Loading

brunotacca commented Dec 26, 2021 via email •

edited

Loading

camsim99 Feb 11, 2022 •

edited

Loading