Skip to content

Build Flutter iOS plugins with all valid architectures #95293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Dec 15, 2021
Merged

Build Flutter iOS plugins with all valid architectures #95293

fluttergithubbot merged 2 commits into from
Dec 15, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 14, 2021 •
edited
Loading

Always build Flutter plugins and their dependencies with all valid iOS architectures so that, if a single plugin does not support arm64 simulators, the app and all frameworks can fall back to x86_64.

Regressed in #90915. That change started telling Xcode which device the binaries would run on, and so Xcode only built arm64 binaries on M1 Macs simulators. However google_sign_in doesn't support arm64 simulators, so when the tool correctly dropped the executable build to x86_64, the other dependencies do not contain x86_64 and linking fails.

Fixes #94914

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Dec 14, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 14, 2021
@jmagman jmagman added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Dec 14, 2021
@jmagman jmagman requested review from cyanglaz and removed request for cyanglaz December 14, 2021 23:11
@jmagman jmagman marked this pull request as draft December 14, 2021 23:15
@jmagman jmagman marked this pull request as ready for review December 14, 2021 23:19
@jmagman jmagman requested a review from cyanglaz December 14, 2021 23:19
cyanglaz
cyanglaz approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 6ab0075 into flutter:master Dec 15, 2021
@jmagman jmagman mentioned this pull request Dec 15, 2021
Closed
@letsar letsar mentioned this pull request Dec 15, 2021
Closed
godofredoc added a commit that referenced this pull request Dec 16, 2021
@godofredoc @jmagman
[flutter_releases] Flutter stable 2.8.1 Framework Cherrypicks (#95375)
77d935a 
* Build Flutter iOS plugins with all valid architectures (#95293)

* 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml'

* 'Update Engine revision to 890a5fca2e34db413be624fc83aeea8e61d42ce6 for stable release 2.8.1'

Co-authored-by: Jenn Magder <[email protected]>
@jmagman jmagman mentioned this pull request Apr 14, 2022
Merged
8 tasks
@jmagman jmagman deleted the m1-sim branch May 4, 2022 02:24
This was referenced May 19, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

M1 iOS simulator app fails to build with with google_sign_in plugin: ld: framework not found Pods_Runner Undefined symbols for architecture x86_64

3 participants

@jmagman @cyanglaz @fluttergithubbot