Skip to content

[tool] xcresult issue discarder #95273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Dec 14, 2021
Merged

[tool] xcresult issue discarder #95273

fluttergithubbot merged 2 commits into from
Dec 14, 2021

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Dec 14, 2021 •
edited
Loading

Add [XCResultIssueDiscarder] to help discard unwanted issues.
This can be used later to discard issues that we don't want when displaying xcresults.

Fixes #95035

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 14, 2021
@cyanglaz cyanglaz requested a review from jmagman December 14, 2021 18:29
cyanglaz
cyanglaz commented Dec 14, 2021
View reviewed changes
packages/flutter_tools/lib/src/ios/xcresult.dart
return false;
}

List<XCResultIssue> _parseIssuesFromIssueSummariesJson({
Copy link
Contributor Author

@cyanglaz cyanglaz Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this private function outside of the `generate' function for cleaner code.
The changes here are adding the discarder logic.

jmagman
jmagman approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e4dadf7 into flutter:master Dec 14, 2021
@cyanglaz cyanglaz deleted the xcresult_filter branch February 16, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xcresult parser should be able to discard error messages we don't want to display.

3 participants

@cyanglaz @jmagman @fluttergithubbot