Update color scheme seed generation to use color utils package #95175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
guidezpl
approved these changes
Dec 13, 2021
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
darrenaustin
suggested changes
Dec 13, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
Thanks for doing this. It was on my list for this morning actually. I originally did something like this but thought it was going to be a more stable implementation and didn't want to have the overhead of constructing Scheme object only to copy all the stuff into the ColorScheme. Given that it has changed already, it makes more sense to rely only the Scheme. I am a little concerned about future changes like this as once this hits stable we won't want to be changing the generated schemes as people may start to depend on them.
All that said, this looks good. However it looks like we need to update the theme_data scheme generation test as it is failing:
darrenaustin
approved these changes
Dec 13, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
LGTM. Thanks again.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version of
material_color_utilitiesand uses theSchemeobject to create the color scheme instead of doing the mappings ourselves. This ensures we match the spec/source of truth for color schemes.Closes #95172
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.