Skip to content

Skip mac/ios test in presubmit #94954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Dec 9, 2021
Merged

Skip mac/ios test in presubmit #94954

fluttergithubbot merged 2 commits into from
Dec 9, 2021

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Dec 9, 2021

@keyonghan keyonghan mentioned this pull request Dec 9, 2021
Closed
christopherfujino
christopherfujino reviewed Dec 9, 2021
View reviewed changes
.ci.yaml Outdated

- name: Mac_ios hot_mode_dev_cycle_macos_target__benchmark
recipe: devicelab/devicelab_drone
presubmit: false
Copy link
Contributor

@christopherfujino christopherfujino Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link #94946 in a comment?

Copy link
Contributor Author

@keyonghan keyonghan Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 😃

christopherfujino
christopherfujino approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f6b9114 into flutter:master Dec 9, 2021
This was referenced Dec 9, 2021
Merged
Merged
@godofredoc godofredoc mentioned this pull request Dec 10, 2021
Merged
godofredoc added a commit that referenced this pull request Dec 10, 2021
@godofredoc
Revert "Skip mac/ios test in presubmit (#94954)"
b824f16 
This reverts commit f6b9114.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keyonghan @christopherfujino @fluttergithubbot