Repository navigation
Consider the FLUTTER_TOOL_ARGS as part of the compilation stamp - #94951
Conversation
|
(still need to update test.dart, but that's blocked on #94879 landing) |
db7a253 to
8e14f85
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
f7ed91a to
15d7ae3
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I suspect the test failures will be fixed (or clarified) by #96320 |
|
Gold has detected about 10 new digest(s) on patchset 1. |
|
Yup, test failures got resolved by that other PR. Marking as ready to land. |
No description provided.