Skip to content

Consider the FLUTTER_TOOL_ARGS as part of the compilation stamp - #94951

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
Hixie:toolstamp
Jan 10, 2022
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
Hixie:toolstamp

Conversation

@Hixie

@Hixie Hixie commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Hixie

Hixie commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

(still need to update test.dart, but that's blocked on #94879 landing)

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Hixie force-pushed the toolstamp branch 2 times, most recently from db7a253 to 8e14f85 Compare December 10, 2021 23:31
@Hixie
Hixie marked this pull request as ready for review December 10, 2021 23:31
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 10, 2021
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Hixie force-pushed the toolstamp branch 7 times, most recently from f7ed91a to 15d7ae3 Compare December 15, 2021 21:11
@flutter-dashboard

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie

Hixie commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

I suspect the test failures will be fixed (or clarified) by #96320

@skia-gold

Copy link
Copy Markdown

Gold has detected about 10 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/94951

@Hixie

Hixie commented Jan 10, 2022

Copy link
Copy Markdown
Contributor Author

Yup, test failures got resolved by that other PR. Marking as ready to land.

@fluttergithubbot
fluttergithubbot merged commit 2835c3f into flutter:master Jan 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants