Repository navigation
Attempt to mitigate flakiness around devtools - #94879
Conversation
flutter-dashboard
Bot
added
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
will this also cause subsequent runs to erroneously re-use the asserts enabled tool snapshot?
There was a problem hiding this comment.
yeah as i was refactoring this code (this function is just an extract of code that was already there twice) i was thinking what we really should do is put the env variables into the snapshot name somehow
There was a problem hiding this comment.
you mean something like flutter_tool_with_asserts.snapshot?
There was a problem hiding this comment.
or all FLUTTER_TOOL_ARGS?
There was a problem hiding this comment.
we could write them to the flutter_tools.stamp file
There was a problem hiding this comment.
yeah, one of those
do you think we should do that in this PR or should i file a bug for now?
There was a problem hiding this comment.
I filed an issue, up to you whether you want to update that here: #94892
There was a problem hiding this comment.
In the interests of keeping this PR simple I'm going to not fix it here but I'll look to see if I can do it as a separate PR.
690ff34 to
bffa378
Compare
bffa378 to
fd294b0
Compare
1eabc0c to
01122c8
Compare
This does three things: * Add more asserts around the devtools launching * Add more defensive checks around the devtools launching in case we're seeing shutdown races * Enable the asserts for the web tests. The idea is to either avoid a flake like this, or make the logs more useful: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828452555087042433/+/u/run_test.dart_for_web_long_running_tests_shard_and_subshard_1_5/test_stdout See also flutter#60239
01122c8 to
6ae6fd9
Compare
This does three things:
The idea is to either avoid a flake like this, or make the logs more useful:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828452555087042433/+/u/run_test.dart_for_web_long_running_tests_shard_and_subshard_1_5/test_stdout
See also #60239