Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Dec 8, 2021

Fix typo in ios module test that caused flakes

Fixes #89175

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 8, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cyanglaz cyanglaz requested a review from jmagman December 8, 2021 19:04
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ good eye. LGTM

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Dec 9, 2021

@jmagman Do you know what's the benchmark failure here? Doesn't seem to relate to the PR but my other framework PR didn't hit this. (This is synced with master)

cc @godofredoc

@jmagman
Copy link
Member

jmagman commented Dec 9, 2021

Lots of infra failures on that benchmark in try jobs: https://ci.chromium.org/p/flutter/builders/try/Mac_ios%20hot_mode_dev_cycle_macos_target__benchmark

File an infra ticket and infra on-call can diagnose.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Dec 9, 2021

Filed #94946

@keyonghan
Copy link
Contributor

Please rebase to pick up #94954 to bypass Mac_ios hot_mode_dev_cycle_macos_target__benchmark failure.

@cyanglaz
Copy link
Contributor Author

ci.yaml validation failed, created infra ticket: #95027

@fluttergithubbot fluttergithubbot merged commit 02574b7 into flutter:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac module_test_ios is 2.76% flaky

4 participants