-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix ios module test typo #94878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ios module test typo #94878
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♀️ good eye. LGTM
|
@jmagman Do you know what's the benchmark failure here? Doesn't seem to relate to the PR but my other framework PR didn't hit this. (This is synced with master) cc @godofredoc |
|
Lots of infra failures on that benchmark in try jobs: https://ci.chromium.org/p/flutter/builders/try/Mac_ios%20hot_mode_dev_cycle_macos_target__benchmark File an infra ticket and infra on-call can diagnose. |
|
Filed #94946 |
|
Please rebase to pick up #94954 to bypass Mac_ios hot_mode_dev_cycle_macos_target__benchmark failure. |
|
ci.yaml validation failed, created infra ticket: #95027 |
Fix typo in ios module test that caused flakes
Fixes #89175
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.