Skip to content

Image color blend mode - #9486

Merged
HansMuller merged 4 commits into
flutter:masterfrom
HansMuller:image_color_blend_mode
Apr 20, 2017
Merged

HansMuller merged 4 commits into
flutter:masterfrom
HansMuller:image_color_blend_mode

Conversation

@HansMuller

@HansMuller HansMuller commented Apr 19, 2017 •

Copy link
Copy Markdown
Contributor

Previously the color's blend mode was always BlendMode.srcIn. That remains the default.

Fixes #9219

@HansMuller
HansMuller force-pushed the image_color_blend_mode branch from 4ced62b to 761d69e Compare April 20, 2017 00:04
///
/// The default is [BlendMode.srcIn]. In terms of the blend mode, [color] is
/// the source and this image is the destination.
BlendMode get colorBlendMode => _colorBlendMode;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please point to [BlendMode] for a discussion of the values and their meanings.

///
/// The default is [BlendMode.srcIn]. In terms of the blend mode, [color] is
/// the source and this image is the destination.
final BlendMode colorBlendMode;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

///
/// The default is [BlendMode.srcIn]. In terms of the blend mode, [color] is
/// the source and this image is the destination.
final BlendMode colorBlendMode;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -100,10 +102,10 @@ class RenderImage extends RenderBox {
if (_color == null)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment? :-)

@Hixie

Hixie commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

LGTM

@HansMuller
HansMuller merged commit 92e40b5 into flutter:master Apr 20, 2017
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

24fps (noticeable) when opening animation demo on Nexus 5

3 participants