Repository navigation
Remove FadeTransition from _MountainViewFadeTransition. - #9472
Merged
Merged
Conversation
xster
approved these changes
Apr 19, 2017
xster
left a comment
xster
left a comment
Contributor
There was a problem hiding this comment.
Are we adding it back after we ship the gallery?
Contributor
|
I think we should add it back (or, at least, turn it on by default) once we're happy with the performance. People will evaluate Flutter by building the Gallery and using our stock components, so we want them to have a good first impression. |
Contributor
|
Can we add this back now? |
Contributor
|
Have we resolved the performance issue? |
passsy
added a commit
to passsy/flutter
that referenced
this pull request
Nov 16, 2017
Fixes flutter#12877 by reverting flutter#9472
Hixie
pushed a commit
that referenced
this pull request
Nov 22, 2017
Hixie
pushed a commit
to Hixie/flutter
that referenced
this pull request
Dec 19, 2017
Hixie
added a commit
that referenced
this pull request
Dec 20, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes perf issues observed on opening all demos in the gallery.