Skip to content

Fixed order dependency and removed no-shuffle-tag in build_ios_framew… #94699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Swiftaxe merged 3 commits into from
Feb 23, 2022
Merged

Fixed order dependency and removed no-shuffle-tag in build_ios_framew… #94699

Swiftaxe merged 3 commits into from
Feb 23, 2022

Conversation

@Swiftaxe
Copy link
Contributor

@Swiftaxe Swiftaxe commented Dec 5, 2021

Fixed order dependency and removed no-shuffle-tag in build_ios_framework_test.dart. Part of #85160.

Another one of these down. This one was a tad more tricky.

The Problem

The tests were failing when using --test-randomize-ordering-seed=1000, and most other seeds as well.

The first three tests in this file set the Cache.flutterRoot variable. This is done by default by the testUsingContext method.
When randomizing the test order the method setUp on line 143 runs cache.getLicenseFile() without Cache.flutterRoot being set. The method getLicenseFile is dependent on flutterRoot being set, so this makes all test in that group fail.

The Solution

Set the Cache.flutterRoot variable, if not set, before calling the method cache.getLicenseFile().

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 5, 2021
@google-cla google-cla bot added the cla: yes label Dec 5, 2021
@Swiftaxe Swiftaxe requested a review from Piinks December 8, 2021 06:05
@google-cla google-cla bot added cla: no and removed cla: yes labels Dec 26, 2021
@skia-gold
Copy link

skia-gold commented Dec 26, 2021

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/94699

Piinks
Piinks reviewed Jan 7, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this to resolve the current test failures? Thanks!

packages/flutter_tools/test/commands.shard/hermetic/build_ios_framework_test.dart Outdated
Copy link
Contributor

@Piinks Piinks Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: revert

Copy link
Contributor Author

@Swiftaxe Swiftaxe Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this to resolve the current test failures? Thanks!

Sorry, you lost me 🙈. Do you want me to rebase, or revert and what commit are we talking about?
Can you be more specific please? 😊

Copy link
Contributor

@Piinks Piinks Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry to be confusing. I meant to ask to revert any unnecessary formatting changes, and to rebase your PR with the latest from master.
The failing customer_testing shard tends to have issues as a PR gets older. Merging in updates from master don't work to resolve it when this happens, it requires rebasing. I hope this is a bit clearer. Let me know if it is not. :)

Copy link
Contributor Author

@Swiftaxe Swiftaxe Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Now I get it =)

packages/flutter_tools/test/commands.shard/hermetic/build_ios_framework_test.dart Outdated
Copy link
Contributor

@Piinks Piinks Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@christopherfujino christopherfujino added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Feb 3, 2022
@Swiftaxe Swiftaxe force-pushed the 85160_build_ios_framework_test branch from 248d54d to 62743f0 Compare February 8, 2022 07:03
@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 8, 2022
christopherfujino
christopherfujino approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added waiting for tree to go green and removed waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds labels Feb 17, 2022
@Swiftaxe Swiftaxe merged commit 4a27374 into flutter:master Feb 23, 2022
@Swiftaxe Swiftaxe deleted the 85160_build_ios_framework_test branch February 23, 2022 07:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
4a27374 Fixed order dependency and removed no-shuffle-tag in build_io…
4c830ec 
…s_framew… (flutter/flutter#94699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
4a27374 Fixed order dependency and removed no-shuffle-tag in build_io…
ae6cbf2 
…s_framew… (flutter/flutter#94699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
4a27374 Fixed order dependency and removed no-shuffle-tag in build_io…
3a1ef41 
…s_framew… (flutter/flutter#94699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
4a27374 Fixed order dependency and removed no-shuffle-tag in build_io…
47cce94 
…s_framew… (flutter/flutter#94699)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@Swiftaxe @clocksmith
Fixed order dependency and removed no-shuffle-tag in build_ios_framew… (
27b0d56 
flutter#94699)

* Fixed order dependency and removed no-shuffle-tag in build_ios_framework_test.dart

* Removed trailing spaces in build_ios_framework_test.dart

* Removed unnecessary formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks left review comments

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Swiftaxe @skia-gold @christopherfujino @Piinks