Detect additional ARM ffi CocoaPods error #94385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
jmagman
commented
Nov 30, 2021
| ); | ||
| expect(usage.events, contains(const TestUsageEvent('pod-install-failure', 'arm-ffi'))); | ||
| final Map<String, String> possibleErrors = <String, String>{ | ||
| 'symbol not found': 'LoadError - dlsym(0x7fbbeb6837d0, Init_ffi_c): symbol not found - /Library/Ruby/Gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle', |
Member
Author
There was a problem hiding this comment.
This is the original message.
| expect(usage.events, contains(const TestUsageEvent('pod-install-failure', 'arm-ffi'))); | ||
| final Map<String, String> possibleErrors = <String, String>{ | ||
| 'symbol not found': 'LoadError - dlsym(0x7fbbeb6837d0, Init_ffi_c): symbol not found - /Library/Ruby/Gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle', | ||
| 'incompatible architecture': "LoadError - (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), '/usr/lib/ffi_c.bundle' (no such file) - /Library/Ruby/Gems/2.6.0/gems/ffi-1.15.4/lib/ffi_c.bundle", |
| 'incompatible architecture': "LoadError - (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), '/usr/lib/ffi_c.bundle' (no such file) - /Library/Ruby/Gems/2.6.0/gems/ffi-1.15.4/lib/ffi_c.bundle", | ||
| }; | ||
| possibleErrors.forEach((String errorName, String cocoaPodsError) { | ||
| testUsingContext('ffi $errorName failure on ARM macOS prompts gem install', () async { |
Member
Author
There was a problem hiding this comment.
Same test, two different errors to parse.
| ); | ||
| } else if (stdout.contains('Init_ffi_c') && | ||
| stdout.contains('symbol not found') && | ||
| } else if (stdout.contains('ffi_c.bundle') && stdout.contains('LoadError') && |
Member
Author
There was a problem hiding this comment.
Both reported errors contain ffi_c.bundle and LoadError.
Member
Author
|
Friendly ping @christopherfujino |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CocoaPods crashes on ARM Macs if the x86 version of the
ffigem isn't installed.#70801 detected one crash, but there have been additional crash messages reported. Parse
LoadErrorand the file in questionffi_c.bundleso users get a prompt in both cases about how to fix it (withsudoso we can't just do it ourselves)Fixes #93908.
Pre-launch Checklist
///).