Added material_color_utilities as a dependency for flutter package. #94377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
HansMuller
approved these changes
Nov 30, 2021
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
The updated analyzer dev dependency seems safe: https://pub.dev/packages/analyzer/changelog
goderbauer
reviewed
Nov 30, 2021
dev/bots/allowlist.dart
Outdated
Member
There was a problem hiding this comment.
This has been cleared with one of the people mentioned in the comment above?
…e, needed for a new ColorScheme generation API.
zanderso
approved these changes
Nov 30, 2021
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
material_color_utilities has no non-dev dependencies, so it will not affect the version of dependencies required for app authors.
lgtm
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add the new ColorScheme generation API (as described in the design doc), we need to add a dependency on
material_color_utilities.Breaking this out from #93463 to make it easier to review the dependency changes independent of the API changes.