Skip to content

Update plugin lint test for federated url_launcher plugin #94374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Nov 29, 2021
Merged

Update plugin lint test for federated url_launcher plugin #94374

jmagman merged 1 commit into from
Nov 29, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 29, 2021 •
edited
Loading

url_launcher is now federated flutter/plugins#4536, and the iOS code lives in url_launcher_ios/ios, not url_launcher/ios.

https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/9398

Fixes #94372

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 29, 2021
@jmagman jmagman self-assigned this Nov 29, 2021
@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@jmagman
Copy link
Member Author

jmagman commented Nov 29, 2021

Mac plugin_lint_mac test passed on this PR: https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/9398

@jmagman
Copy link
Member Author

jmagman commented Nov 29, 2021

Expect Linux flutter_plugins to still fail. See #94369.

@jmagman jmagman mentioned this pull request Nov 29, 2021
Merged
@jmagman
Copy link
Member Author

jmagman commented Nov 29, 2021

Merging to fix one of the failing tests closing the tree.

@jmagman jmagman merged commit 86b80d1 into flutter:master Nov 29, 2021
@jmagman jmagman deleted the url-launcher branch November 29, 2021 20:19
godofredoc added a commit that referenced this pull request Dec 1, 2021
@godofredoc @yjbanov @jmagman
[flutter_releases] Flutter beta 2.8.0-3.3.pre Framework Cherrypicks (#…
262b70e 
…94490)

* make CIPD url customizable using FLUTTER_STORAGE_BASE_URL (#94137)

* 'Update Engine revision to 06a7363 for beta release 2.8.0-3.3.pre'

* Update plugin lint test for federated url_launcher plugin (#94374)

Co-authored-by: Yegor <[email protected]>
Co-authored-by: Jenn Magder <[email protected]>
ryanawhelan pushed a commit to ryanawhelan/flutter that referenced this pull request Jan 13, 2022
@godofredoc @yjbanov
@jmagman @ryanawhelan
[flutter_releases] Flutter beta 2.8.0-3.3.pre Framework Cherrypicks (f…
4464eae 
…lutter#94490)

* make CIPD url customizable using FLUTTER_STORAGE_BASE_URL (flutter#94137)

* 'Update Engine revision to 06a7363 for beta release 2.8.0-3.3.pre'

* Update plugin lint test for federated url_launcher plugin (flutter#94374)

Co-authored-by: Yegor <[email protected]>
Co-authored-by: Jenn Magder <[email protected]>
@jmagman jmagman mentioned this pull request Feb 10, 2022
Closed
jmagman added a commit that referenced this pull request Feb 10, 2022
@jmagman
Revert "Update plugin lint test for federated url_launcher plugin (#9…
4086af0 
…4374)"

This reverts commit 86b80d1.
@jmagman jmagman mentioned this pull request Feb 10, 2022
Merged
jmagman added a commit that referenced this pull request Feb 10, 2022
@jmagman
Revert "Update plugin lint test for federated url_launcher plugin (#9…
4d0235a 
…4374)"

This reverts commit 86b80d1.
jmagman added a commit that referenced this pull request Feb 10, 2022
@jmagman
Revert "Update plugin lint test for federated url_launcher plugin (#9…
ea6025c 
…4374)" (#98166)

This reverts commit 86b80d1.
jmagman added a commit to jmagman/flutter that referenced this pull request Feb 11, 2022
@jmagman
Revert "Revert "Update plugin lint test for federated url_launcher pl…
a4a8dfe 
…ugin (flutter#94374)" (flutter#98166)"

This reverts commit ea6025c.
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Revert "Update plugin lint test for federated url_launcher plugin (fl…
2d1ea74 
…utter#94374)" (flutter#98166)

This reverts commit 86b80d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Mac plugin_lint_mac" failing "iOS Podfile.lock does not contain expected pods"

2 participants

@jmagman @zanderso