It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

I doubt this will re-open the tree, the failing test doesn't use the plugin roll SHA.

Oh, actually it will help Linux flutter_plugins but not Mac plugin_lint_mac.

info - example/lib/web_view.dart:550:37 - Prefer const with constant constructors. - prefer_const_constructors

@bparrishMines plugins sheriff

@mvanbeusekom re: lint error flutter/plugins#4553

The Mac plugin_lint_mac failure is due to url_plugin being federated. I'll get a fix out.
flutter/plugins@a456f63

The Mac plugin_lint_mac failure is due to url_plugin being federated. I'll get a fix out. flutter/plugins@a456f63

#94372

Hm, this roll revert didn't fix Linux flutter_plugins

   info - example/lib/web_view.dart:550:37 - Prefer const with constant constructors. - prefer_const_constructors

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8829201417244925441/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/test_stdout

I think it needs to be rolled to flutter/plugins@6bc9a2b. We should instead merge #94352.

@jmagman To clarify, are you saying that we should abandon this PR, and instead merge #94352?

@jmagman To clarify, are you saying that we should abandon this PR, and instead merge #94352?

Yes, this isn't the right SHA to revert to, it didn't fix Linux flutter_plugins . Actually #94352 had a failing ci.yaml roll test and all the tests were queued, and I don't know how to kick the tests. I created an identical manual roll at #94375