Repository navigation
Added isExpanded field to ExpansionTile widget - #93849
Closed
happy-cat-coder wants to merge 2 commits into
Closed
happy-cat-coder wants to merge 2 commits into
happy-cat-coder wants to merge 2 commits into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
Bot
added
p: material_ui
happy-cat-coder
force-pushed
the
master
branch
from
November 18, 2021 10:27
4eb94fb to
1714913
Compare
happy-cat-coder
marked this pull request as draft
November 19, 2021 14:56
|
any update on it? |
happy-cat-coder
marked this pull request as ready for review
December 14, 2021 13:46
goderbauer
reviewed
Dec 15, 2021
Member
|
Unfortunately, an API like that doesn't work as explained in the comment. |
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR make the
ExpansionTilewidget able to expand and collapse programmatically by adding the public fieldisExpandedand listen for it's updates.This MR is a fix for #60387 .
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.