Skip to content

Update CupertinoTextField example #93738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 15, 2022
Merged

Update CupertinoTextField example #93738

fluttergithubbot merged 1 commit into from
Feb 15, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Nov 16, 2021

Related #72926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 16, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 16, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 16, 2021
gspencergoog
gspencergoog requested changes Nov 16, 2021
View reviewed changes
gspencergoog
gspencergoog reviewed Nov 16, 2021
View reviewed changes
@skia-gold
Copy link

skia-gold commented Feb 4, 2022

Gold has detected about 61 new digest(s) on patchset 6.
View them at https://flutter-gold.skia.org/cl/github/93738

gspencergoog
gspencergoog approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog
Copy link
Contributor

gspencergoog commented Feb 14, 2022

I'm not sure what's up with the golden test message... I think you can ignore it.

@TahaTesser
Update CupertinoTextField example and add test
ac49d83 
Remove doc lines for doc in the example snippet

fix example class name

fix example location

fix doc

fix example description
@fluttergithubbot fluttergithubbot merged commit dfd4244 into flutter:master Feb 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
dfd4244 Update CupertinoTextField example (flutter/flutter#93738)
7e2bdb7
@TahaTesser TahaTesser deleted the cupertino_textfield_example branch February 15, 2022 17:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
dfd4244 Update CupertinoTextField example (flutter/flutter#93738)
c857587
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
dfd4244 Update CupertinoTextField example (flutter/flutter#93738)
965d50c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
dfd4244 Update CupertinoTextField example (flutter/flutter#93738)
361852b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
dfd4244 Update CupertinoTextField example (flutter/flutter#93738)
9bf8910
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
dfd4244 Update CupertinoTextField example (flutter/flutter#93738)
1685b21
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Update CupertinoTextField example (flutter#93738)
0ebb2ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TahaTesser @skia-gold @gspencergoog @fluttergithubbot